* lib/Makefile.am (AM_CFLAGS): Remove $(WERROR_CFLAGS).

Problem reported by Joel E. Denny.

2006-10-14  Jim Meyering  <jim@meyering.net>

(Sync from coreutils.)
Work also when the working directory (with e.g. coreutils sources)
is version controlled with git, rather than CVS.
* bootstrap (CVS_only_file): Test for the existence of README-cvs,
rather than CVS.
In messages and comments, say e.g., "checked-out sources",
rather than "CVS sources".
(version_controlled_file): New function.  Work for git as well as
for CVS.  Don't use grep's -q option.
(slurp): Call it here, in place of CVS-specific code.
This commit is contained in:
Paul Eggert
2006-10-15 04:31:23 +00:00
parent c4bd5bf7c5
commit 10f429ef19
3 changed files with 42 additions and 9 deletions

View File

@@ -1,3 +1,21 @@
2006-10-14 Paul Eggert <eggert@cs.ucla.edu>
* lib/Makefile.am (AM_CFLAGS): Remove $(WERROR_CFLAGS).
Problem reported by Joel E. Denny.
2006-10-14 Jim Meyering <jim@meyering.net>
(Sync from coreutils.)
Work also when the working directory (with e.g. coreutils sources)
is version controlled with git, rather than CVS.
* bootstrap (CVS_only_file): Test for the existence of README-cvs,
rather than CVS.
In messages and comments, say e.g., "checked-out sources",
rather than "CVS sources".
(version_controlled_file): New function. Work for git as well as
for CVS. Don't use grep's -q option.
(slurp): Call it here, in place of CVS-specific code.
2006-10-14 Joel E. Denny <jdenny@ces.clemson.edu> 2006-10-14 Joel E. Denny <jdenny@ces.clemson.edu>
Fix testsuite for ./configure --enable-gcc-warnings: Fix testsuite for ./configure --enable-gcc-warnings:

View File

@@ -32,7 +32,7 @@ export LC_ALL
usage() { usage() {
echo >&2 "\ echo >&2 "\
Usage: $0 [OPTION]... Usage: $0 [OPTION]...
Bootstrap this package from the CVS sources. Bootstrap this package from the checked-out sources.
Options: Options:
--gnulib-srcdir=DIRNAME Specify the local directory where gnulib --gnulib-srcdir=DIRNAME Specify the local directory where gnulib
@@ -41,7 +41,8 @@ Options:
do not want to waste your bandwidth dowloading do not want to waste your bandwidth dowloading
them again. them again.
--copy Copy files instead of creating symbolic links. --copy Copy files instead of creating symbolic links.
--force Bootstrap even if the sources didn't come from CVS. --force Attempt to bootstrap even if the sources seem
not to have been checked out.
--skip-po Do not download po files. --skip-po Do not download po files.
--cvs-user=USERNAME Set the CVS username to be used when accessing --cvs-user=USERNAME Set the CVS username to be used when accessing
the gnulib repository. the gnulib repository.
@@ -109,9 +110,9 @@ XGETTEXT_OPTIONS='\\\
# Files we don't want to import. # Files we don't want to import.
excluded_files= excluded_files=
# File that should exist with CVS checkout, but not with # File that should exist in the top directory of a checked out hierarchy,
# the distributed version. # but not in a distribution tarball.
CVS_only_file=CVS CVS_only_file=README-cvs
# Whether to use copies instead of symlinks. # Whether to use copies instead of symlinks.
copy=false copy=false
@@ -146,7 +147,7 @@ do
done done
if test -n "$CVS_only_file" && test ! -r "$CVS_only_file"; then if test -n "$CVS_only_file" && test ! -r "$CVS_only_file"; then
echo "$0: Bootstrapping from a non-CVS distribution is a bit risky." >&2 echo "$0: Bootstrapping from a non-checked-out distribution is risky." >&2
exit 1 exit 1
fi fi
@@ -334,6 +335,21 @@ cp_mark_as_generated()
fi fi
} }
version_controlled_file() {
dir=$1
file=$2
found=no
if test -d CVS; then
grep -F "/$file/" $dir/CVS/Entries 2>/dev/null |
grep '^/[^/]*/[0-9]' > /dev/null && found=yes
elif test -d .git; then
git-rm -n "$dir/$file" > /dev/null 2>&1 && found=yes
else
echo "$0: no version control for $dir/$file?" >&2
fi
test $found = yes
}
slurp() { slurp() {
for dir in . `(cd $1 && find * -type d -print)`; do for dir in . `(cd $1 && find * -type d -print)`; do
copied= copied=
@@ -352,8 +368,7 @@ slurp() {
sed "$remove_intl" $1/$dir/$file >$dir/gnulib.mk sed "$remove_intl" $1/$dir/$file >$dir/gnulib.mk
} }
elif { test "${2+set}" = set && test -r $2/$dir/$file; } || elif { test "${2+set}" = set && test -r $2/$dir/$file; } ||
grep -F "/$file/" $dir/CVS/Entries 2>/dev/null | version_controlled_file $dir $file; then
grep -q '^/[^/]*/[0-9]'; then
echo "$0: $dir/$file overrides $1/$dir/$file" echo "$0: $dir/$file overrides $1/$dir/$file"
else else
copied=$copied$sep$file; sep=$nl copied=$copied$sep$file; sep=$nl

View File

@@ -19,7 +19,7 @@
include gnulib.mk include gnulib.mk
AM_CFLAGS = $(WARNING_CFLAGS) $(WERROR_CFLAGS) AM_CFLAGS = $(WARNING_CFLAGS)
# Implementation of bitsets. # Implementation of bitsets.
bitsets_sources = \ bitsets_sources = \