Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-13 14:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixits: suggest running --update if there are fixits

Browse Source 
* src/fixits.h, src/fixits.c (fixits_empty): New.
* src/complain.c (deprecated_directive): Register the Wdeprecated
fixits only if -Wdeprecated was enabled, so that we don't apply
updates if the user didn't ask for them.
* src/main.c (main): If there were fixits, issue a warning suggesting
running with --update.
Free uniqstrs after the fixits, since the latter use the former.
* tests/headers.at, tests/input.at: Update expectations.
This commit is contained in:
Akim Demaille
2019-01-15 21:00:41 +01:00
parent b7e0d3131d
commit 169fe80c7f
6 changed files with 35 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/main.c
View File

@@ -103,12 +103,6 @@ main (int argc, char *argv[])
reader ();
timevar_pop (tv_reader);
/* Fix input file now, even if there are errors: that's less
warnings in the following runs. */
if (update_flag)
fixits_run ();
fixits_free ();
if (complaint_status == status_complaint)
goto finish;
@@ -217,7 +211,6 @@ main (int argc, char *argv[])
contains things such as user actions, prologue, epilogue etc. */
gram_scanner_free ();
muscle_free ();
uniqstrs_free ();
code_scanner_free ();
skel_scanner_free ();
quotearg_free ();
@@ -234,5 +227,18 @@ main (int argc, char *argv[])
cleanup_caret ();
/* Fix input file now, even if there are errors: that's less
warnings in the following runs. */
if (!fixits_empty ())
{
if (update_flag)
fixits_run ();
else
complain (NULL, Wother,
_("fix-its can be applied. Rerun with option '--update'."));
fixits_free ();
}
uniqstrs_free ();
return complaint_status ? EXIT_FAILURE : EXIT_SUCCESS;
}