Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-09 12:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: beware of portability issues with wc

Browse Source 
On macOS, wc -l always prepends the result with a tab, even when fed
by stdin.  But anyway, we should have used `grep -c -v`, which appears
to be portable according to Autoconf's "Limitations of Usual Tools"
section.
Reported by Denis Excoffier.
https://lists.gnu.org/r/bug-bison/2020-04/msg00009.html

* tests/calc.at (_AT_CHECK_CALC): Use grep's -c instead.
This commit is contained in:
Akim Demaille
2020-04-19 08:05:35 +02:00
parent 0a64b76430
commit 1d0e3ee896
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/calc.at
View File

@@ -763,8 +763,8 @@ AT_JAVA_IF(
[AT_PARSER_CHECK([calc input], 0, [AT_PARAM_IF([m4_n([$3])])], [stderr])]) [AT_PARSER_CHECK([calc input], 0, [AT_PARAM_IF([m4_n([$3])])], [stderr])])
AT_LANG_MATCH([c\|c++\|java], AT_LANG_MATCH([c\|c++\|java],
[AT_GLR_IF([], [AT_GLR_IF([],
[AT_CHECK([grep -v 'Return for a new token:' stderr | wc -l], [AT_CHECK([grep -c -v 'Return for a new token:' stderr],
[0], [ignore],
[m4_n([AT_DEBUG_IF([$4], [0])])])])]) [m4_n([AT_DEBUG_IF([$4], [0])])])])])
]) ])

2
tests/local.at
View File

@@ -1601,7 +1601,7 @@ $9
# (C90 and C++98) guarantee: 32767. In that case, GCC's -pedantic # (C90 and C++98) guarantee: 32767. In that case, GCC's -pedantic
# will issue an error. # will issue an error.
# #
# There is no "" around `wc` since some indent the result. # There is no "" around `wc` since some wc indent the result.
m4_bmatch([$4], [%define lr.type canonical-lr], m4_bmatch([$4], [%define lr.type canonical-lr],
[if test 32767 -lt `wc -l < input.c`; then [if test 32767 -lt `wc -l < input.c`; then
CFLAGS=`echo " $CFLAGS " | sed -e 's/ -pedantic / /'` CFLAGS=`echo " $CFLAGS " | sed -e 's/ -pedantic / /'`