From 32b9dcecc75e8510c3f7beda0b060e96b31f1b1f Mon Sep 17 00:00:00 2001 From: Akim Demaille Date: Tue, 29 Jan 2019 23:04:00 +0100 Subject: [PATCH] style: sort includes and avoid assignments * src/symtab.c: Sort includes. * src/gram.c (grammar_rules_print_xml): Avoid assignments to define 'usefulness'. --- src/gram.c | 11 ++++------- src/symtab.c | 3 ++- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/gram.c b/src/gram.c index 19c588d6..2f094944 100644 --- a/src/gram.c +++ b/src/gram.c @@ -218,13 +218,10 @@ grammar_rules_print_xml (FILE *out, int level) xml_puts (out, level + 1, ""); first = false; { - char const *usefulness; - if (rule_useless_in_grammar_p (&rules[r])) - usefulness = "useless-in-grammar"; - else if (rule_useless_in_parser_p (&rules[r])) - usefulness = "useless-in-parser"; - else - usefulness = "useful"; + char const *usefulness + = rule_useless_in_grammar_p (&rules[r]) ? "useless-in-grammar" + : rule_useless_in_parser_p (&rules[r]) ? "useless-in-parser" + : "useful"; xml_indent (out, level + 2); fprintf (out, ". */ #include +#include "symtab.h" + #include "system.h" #include #include "complain.h" #include "gram.h" -#include "symtab.h" /*-------------------------------------------------------------------. | Symbols sorted by tag. Allocated by the first invocation of |