Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-09 12:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixits: handle per-rule duplicates

Browse Source 
* src/complain.c (duplicate_rule_directive): Here.
* tests/actions.at (Invalid uses of %empty): Check it.
This commit is contained in:
Akim Demaille
2019-01-17 06:44:51 +01:00
parent d5d148630a
commit 5879c8dc5a
2 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/complain.c
View File

@@ -421,4 +421,5 @@ duplicate_rule_directive (char const *directive,
complain_indent (&second, complaint, &i, _("only one %s allowed per rule"), directive); complain_indent (&second, complaint, &i, _("only one %s allowed per rule"), directive);
i += SUB_INDENT; i += SUB_INDENT;
complain_indent (&first, complaint, &i, _("previous declaration")); complain_indent (&first, complaint, &i, _("previous declaration"));
fixits_register (&second, "");
} }

27
tests/actions.at
View File

@@ -174,8 +174,35 @@ AT_BISON_CHECK([-fcaret one.y], [1], [],
one.y:11.3-8: previous declaration one.y:11.3-8: previous declaration
%empty {} %empty %empty {} %empty
^~~~~~ ^~~~~~
one.y: warning: fix-its can be applied. Rerun with option '--update'. [-Wother]
]]) ]])
AT_BISON_CHECK([-fcaret -u one.y], [1], [],
[[one.y:11.13-18: error: only one %empty allowed per rule
%empty {} %empty
^~~~~~
one.y:11.3-8: previous declaration
%empty {} %empty
^~~~~~
bison: file 'one.y' was updated (backup: 'one.y~')
]])
AT_CHECK([cat one.y], [],
[[%code top {
/* Load config.h, and adjust to the compiler.
We used to do it here, but each time we add a new line,
we have to adjust all the line numbers in error messages.
It's simpler to use a constant include to a varying file. */
#include <testsuite.h>
}
%%
exp:
%empty {} @&t@
;
]])
AT_DATA_GRAMMAR([[two.y]], AT_DATA_GRAMMAR([[two.y]],
[[%% [[%%
exp: exp: