Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-15 07:13:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Also warn about non-used mid-rule values.

Browse Source 
* src/symlist.h, src/symlist.c (symbol_list): Add a mid_rule
member.
(symbol_list_new): Adjust.
* src/reader.c (symbol_typed_p): New.
(grammar_rule_check): Use it.
(grammar_midrule_action): Bind a mid-rule LHS to its rule.
Check its rule.
* tests/input.at (AT_CHECK_UNUSED_VALUES): New.
Use it.
* tests/actions.at (Exotic Dollars): Adjust.
This commit is contained in:
Akim Demaille
2006-01-04 09:18:37 +00:00
parent 378f4bd846
commit 8486615972
7 changed files with 115 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/actions.at
View File

@@ -113,6 +113,7 @@ AT_DATA_GRAMMAR([[input.y]],
exp: a_1 a_2 { $<val>$ = 3; } { $<val>$ = $<val>3 + 1; } a_5
sum_of_the_five_previous_values
{
USE (($1, $2, $<foo>3, $<foo>4, $5));
printf ("%d\n", $6);
}
;
@@ -146,11 +147,7 @@ main (void)
}
]])
AT_CHECK([bison -d -v -o input.c input.y], 0, [],
[input.y:30.6-34.5: warning: unused value: $1
input.y:30.6-34.5: warning: unused value: $2
input.y:30.6-34.5: warning: unused value: $5
])
AT_CHECK([bison -d -v -o input.c input.y], 0)
AT_COMPILE([input])
AT_PARSER_CHECK([./input], 0,
[[15

91
tests/input.at
View File

@@ -86,51 +86,80 @@ AT_CLEANUP
## Unused values. ##
## --------------- ##
AT_SETUP([Unused values])
m4_define([AT_CHECK_UNUSED_VALUES],
[AT_SETUP([Unused values])
AT_DATA([input.y],
[[%token <integer> INT
%type <integer> exp
%%
exp:
INT { } INT { } INT { }
/* Ideally we would like to complain also about $2 and $4 here, but
it's hard to implement. */
| INT { $$ } INT { $$ } INT { }
| INT { $1 } INT { } INT { }
| INT { } INT { $1 } INT { }
| INT { } INT { } INT { $1 }
| INT { } INT { } INT { $$ = $1 + $3 + $5; }
$1
| INT
;
]])
AT_CHECK([bison input.y], [], [],
[[input.y:5.3-25: warning: unset value: $$
[[$2]])
AT_CLEANUP
])
AT_CHECK_UNUSED_VALUES([INT { } INT { } INT { }],
[input.y:5.3-25: warning: unset value: $$
input.y:5.3-25: warning: unused value: $1
input.y:5.3-25: warning: unused value: $3
input.y:5.3-25: warning: unused value: $5
input.y:8.3-31: warning: unset value: $$
input.y:8.3-31: warning: unused value: $1
input.y:8.3-31: warning: unused value: $3
input.y:8.3-31: warning: unused value: $5
input.y:9.3-28: warning: unset value: $$
input.y:9.3-28: warning: unused value: $3
input.y:9.3-28: warning: unused value: $5
input.y:10.3-28: warning: unset value: $$
input.y:10.3-28: warning: unused value: $3
input.y:10.3-28: warning: unused value: $5
input.y:11.3-29: warning: unset value: $$
input.y:11.3-29: warning: unused value: $3
input.y:11.3-29: warning: unused value: $5
input.y: conflicts: 1 reduce/reduce
input.y:8.7-12: warning: rule never reduced because of conflicts: @3: /* empty */
input.y:9.7-12: warning: rule never reduced because of conflicts: @5: /* empty */
input.y:10.7-9: warning: rule never reduced because of conflicts: @7: /* empty */
input.y:11.7-9: warning: rule never reduced because of conflicts: @9: /* empty */
input.y:12.7-9: warning: rule never reduced because of conflicts: @11: /* empty */
]])
])
AT_CHECK_UNUSED_VALUES([INT { $1 } INT { } INT { }],
[input.y:5.3-28: warning: unset value: $$
input.y:5.3-28: warning: unused value: $3
input.y:5.3-28: warning: unused value: $5
])
AT_CHECK_UNUSED_VALUES([INT { } INT { $1 } INT { }],
[input.y:5.3-28: warning: unset value: $$
input.y:5.3-28: warning: unused value: $3
input.y:5.3-28: warning: unused value: $5
])
AT_CHECK_UNUSED_VALUES([INT { } INT { } INT { $1 }],
[input.y:5.3-29: warning: unset value: $$
input.y:5.3-29: warning: unused value: $3
input.y:5.3-29: warning: unused value: $5
])
AT_CHECK_UNUSED_VALUES([INT { } INT { } INT { $$ = $1 + $3 + $5; }])
# Checking mid-rule values.
AT_CHECK_UNUSED_VALUES([INT { $$ } INT { $$ } INT { }],
[input.y:5.3-31: warning: unset value: $$
input.y:5.3-31: warning: unused value: $1
input.y:5.3-31: warning: unused value: $2
input.y:5.3-31: warning: unused value: $3
input.y:5.3-31: warning: unused value: $4
input.y:5.3-31: warning: unused value: $5
])
AT_CHECK_UNUSED_VALUES([INT { $$ } INT { $$ = $2 } INT { }],
[input.y:5.3-36: warning: unset value: $$
input.y:5.3-36: warning: unused value: $1
input.y:5.3-36: warning: unused value: $3
input.y:5.3-36: warning: unused value: $4
input.y:5.3-36: warning: unused value: $5
])
# AT_CHECK_UNUSED_VALUES([INT { $$ } { $$ = $2 } { }],
# [input.y:5.3-36: warning: unset value: $$
# input.y:5.3-36: warning: unused value: $1
# input.y:5.3-36: warning: unused value: $3
# input.y:5.3-36: warning: unused value: $4
# input.y:5.3-36: warning: unused value: $5
# ])
AT_CHECK_UNUSED_VALUES([INT { $$ = $1 } INT { $$ = $2 + $3 } INT { $$ = $4 + $5 }])
AT_CLEANUP
## ---------------------- ##