Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-12 05:43:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

named references: fix double free.

Browse Source 
In `rhs[name]: "a" | "b"', do not free "name" twice.
Reported by Tys Lefering.
<http://lists.gnu.org/archive/html/bug-bison/2010-06/msg00002.html>

	* src/named-ref.h, src/named-ref.c (named_ref_copy): New.
	* src/parse-gram.y (current_lhs): Rename as...
	(current_lhs_symbol): this.
	(current_lhs): New function.  Use it to free the current lhs
	named reference.
	* src/reader.c: Bind lhs to a copy of the current named reference.
	* src/symlist.c: Rely on free (0) being valid.
	* tests/named-refs.at: Test this.
This commit is contained in:
Akim Demaille
2011-03-02 17:06:58 +01:00
parent 686e83e396
commit 8f462efe92
8 changed files with 66 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/reader.c
View File

@@ -231,7 +231,7 @@ grammar_current_rule_begin (symbol *lhs, location loc,
p = grammar_symbol_append (lhs, loc);
if (lhs_name)
assign_named_ref(p, lhs_name);
assign_named_ref (p, named_ref_copy (lhs_name));
current_rule = grammar_end;