Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-19 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: prefer symbolic values rather than litterals

Browse Source 
Instead of

    #define YYPACT_NINF -130
    #define yypact_value_is_default(Yystate) \
      (!!((Yystate) == (-130)))

generate

    #define YYPACT_NINF (-130)
    #define yypact_value_is_default(Yyn) \
      ((Yyn) == YYPACT_NINF)

* data/skeletons/c.m4 (b4_table_value_equals): Add support for $4.
* data/skeletons/glr.c, data/skeletons/yacc.c: Use it.
Also, use shorter macro argument names, the name of the macro is clear
enough.
This commit is contained in:
Akim Demaille
2019-09-30 07:17:01 +02:00
parent 4971409e39
commit a57e74a5bf
3 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
data/skeletons/c.m4
View File

@@ -189,16 +189,16 @@ m4_define([b4_int_type_for],
[b4_int_type($1_min, $1_max)]) [b4_int_type($1_min, $1_max)])
# b4_table_value_equals(TABLE, VALUE, LITERAL) # b4_table_value_equals(TABLE, VALUE, LITERAL, SYMBOL)
# -------------------------------------------- # ----------------------------------------------------
# Without inducing a comparison warning from the compiler, check if the # Without inducing a comparison warning from the compiler, check if the
# literal value LITERAL equals VALUE from table TABLE, which must have # literal value LITERAL equals VALUE from table TABLE, which must have
# TABLE_min and TABLE_max defined. # TABLE_min and TABLE_max defined. SYMBOL denotes
m4_define([b4_table_value_equals], m4_define([b4_table_value_equals],
[m4_if(m4_eval($3 < m4_indir([b4_]$1[_min]) [m4_if(m4_eval($3 < m4_indir([b4_]$1[_min])
|| m4_indir([b4_]$1[_max]) < $3), [1], || m4_indir([b4_]$1[_max]) < $3), [1],
[[0]], [[0]],
[(!!(($2) == ($3)))])]) [(($2) == $4)])])
## ----------------- ## ## ----------------- ##

10
data/skeletons/glr.c
View File

@@ -375,8 +375,8 @@ static const char *const yytname[] =
}; };
#endif #endif
#define YYPACT_NINF ]b4_pact_ninf[ #define YYPACT_NINF (]b4_pact_ninf[)
#define YYTABLE_NINF ]b4_table_ninf[ #define YYTABLE_NINF (]b4_table_ninf[)
]b4_parser_tables_define[ ]b4_parser_tables_define[
@@ -968,7 +968,7 @@ yylhsNonterm (yyRuleNum yyrule)
} }
#define yypact_value_is_default(Yyn) \ #define yypact_value_is_default(Yyn) \
]b4_table_value_equals([[pact]], [[Yyn]], [b4_pact_ninf])[ ]b4_table_value_equals([[pact]], [[Yyn]], [b4_pact_ninf], [YYPACT_NINF])[
/** True iff LR state YYSTATE has only a default reduction (regardless /** True iff LR state YYSTATE has only a default reduction (regardless
* of token). */ * of token). */
@@ -985,8 +985,8 @@ yydefaultAction (yyStateNum yystate)
return yydefact[yystate]; return yydefact[yystate];
} }
#define yytable_value_is_error(Yytable_value) \ #define yytable_value_is_error(Yyn) \
]b4_table_value_equals([[table]], [[Yytable_value]], [b4_table_ninf])[ ]b4_table_value_equals([[table]], [[Yyn]], [b4_table_ninf], [YYTABLE_NINF])[
/** The action to take in YYSTATE on seeing YYTOKEN. /** The action to take in YYSTATE on seeing YYTOKEN.
* Result R means * Result R means

10
data/skeletons/yacc.c
View File

@@ -643,15 +643,15 @@ static const ]b4_int_type_for([b4_toknum])[ yytoknum[] =
}; };
# endif # endif
#define YYPACT_NINF ]b4_pact_ninf[ #define YYPACT_NINF (]b4_pact_ninf[)
#define yypact_value_is_default(Yyn) \ #define yypact_value_is_default(Yyn) \
]b4_table_value_equals([[pact]], [[Yyn]], [b4_pact_ninf])[ ]b4_table_value_equals([[pact]], [[Yyn]], [b4_pact_ninf], [YYPACT_NINF])[
#define YYTABLE_NINF ]b4_table_ninf[ #define YYTABLE_NINF (]b4_table_ninf[)
#define yytable_value_is_error(Yytable_value) \ #define yytable_value_is_error(Yyn) \
]b4_table_value_equals([[table]], [[Yytable_value]], [b4_table_ninf])[ ]b4_table_value_equals([[table]], [[Yyn]], [b4_table_ninf], [YYTABLE_NINF])[
]b4_parser_tables_define[ ]b4_parser_tables_define[