Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-11 13:23:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

warnings: used but undeclared symbols are warnings

Browse Source 
We used to raise an error if a symbol appears only in a %printer or
%destructor.  Make it a warning.

* src/symtab.h (status): New enum.
(symbol): Replace the binary "declared" with the three-state "status".
Adjust dependencies.
* src/symtab.c (symbol_check_defined): Needed symbols are an error,
whereas "used" are simply warnings.
* src/symlist.c (symbol_list_destructor_set, symbol_list_printer): Set
symbol status to 'used' when associated to destructors or printers.
* input.at (Undeclared symbols used for a printer or destructor): New.
This commit is contained in:
Victor Santet
2012-06-19 16:14:55 +02:00
committed by Akim Demaille
parent dda2c1adba
commit b921d92fcb
6 changed files with 66 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/symtab.c
View File

@@ -85,7 +85,7 @@ symbol_new (uniqstr tag, location loc)
res->alias = NULL;
res->class = unknown_sym;
res->declared = false;
res->status = needed;
if (nsyms == SYMBOL_NUMBER_MAXIMUM)
fatal (_("too many symbols in input grammar (limit is %d)"),
@@ -361,7 +361,7 @@ symbol_class_set (symbol *sym, symbol_class class, location loc, bool declaring)
if (sym->class != unknown_sym && sym->class != class)
{
complain_at (loc, _("symbol %s redefined"), sym->tag);
sym->declared = false;
sym->status = needed;
}
if (class == nterm_sym && sym->class != nterm_sym)
@@ -373,9 +373,9 @@ symbol_class_set (symbol *sym, symbol_class class, location loc, bool declaring)
if (declaring)
{
if (sym->declared)
if (sym->status == declared)
warn_at (loc, _("symbol %s redeclared"), sym->tag);
sym->declared = true;
sym->status = declared;
}
}
@@ -421,10 +421,19 @@ symbol_check_defined (symbol *sym)
{
if (sym->class == unknown_sym)
{
complain_at
(sym->location,
_("symbol %s is used, but is not defined as a token and has no rules"),
sym->tag);
if (sym->status == needed)
complain_at
(sym->location,
_("symbol %s is used, but is not defined as a token and has no"
" rules"),
sym->tag);
else
warn_at
(sym->location,
_("symbol %s is used, but is not defined as a token and has no"
" rules"),
sym->tag);
sym->class = nterm_sym;
sym->number = nvars++;
}