Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-13 06:13:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

warnings: introduce -Wprecedence

Browse Source 
The new warning category "precedence" flags useless precedence and
associativity.  -Wprecedence can now be used, it is disabled by default.
The warnings about precedence and associativity are grouped into one, and
the testsuite was corrected accordingly.

* src/complain.h (warnings): Introduce "precedence".
* src/complain.c (warnings_print_categories): Adjust.
* src/getargs.c (warnings_args, warning_types): Likewise.
* src/symtab.h, src/symtab.c (print_associativity_warnings): Remove.
* src/symtab.h (register_assoc): Correct arguments.
* src/symtab.c (print_precedence_warnings): Print both warnings together.
* doc/bison.texi (Bison options): Document the warnings and provide an
example.
* tests/conflicts.at, tests/existing.at, tests/local.at,
* tests/regression.at: Adapt the testsuite for the new category
(-Wprecedence instead of -Wother where appropriate).
This commit is contained in:
Valentin Tolmer
2013-01-30 11:30:15 +01:00
committed by Akim Demaille
parent df1ca1b0de
commit cc2235ace2
12 changed files with 331 additions and 232 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
src/symtab.c
View File

@@ -1057,29 +1057,6 @@ register_precedence (graphid first, graphid snd)
}
/*--------------------------------------------------.
| Print a warning for unused precedence relations. |
`--------------------------------------------------*/
void
print_precedence_warnings (void)
{
int i;
if (!prec_nodes)
init_prec_nodes ();
for (i = 0; i < nsyms; ++i)
{
symbol *s = symbols[i];
if (s
&& s->prec != 0
&& !prec_nodes[i]->pred
&& !prec_nodes[i]->succ
&& s->assoc == precedence_assoc)
complain (&s->location, Wother,
_("useless precedence for %s"), s->tag);
}
}
/*---------------------------------------.
| Initialize association tracking table. |
`---------------------------------------*/
@@ -1119,21 +1096,35 @@ register_assoc (graphid i, graphid j)
used_assoc[j] = true;
}
/*------------------------------------------------------.
| Print a warning for each unused symbol associativity. |
`------------------------------------------------------*/
/*--------------------------------------------------.
| Print a warning for unused precedence relations. |
`--------------------------------------------------*/
void
print_assoc_warnings (void)
print_precedence_warnings (void)
{
graphid i;
int i;
if (!prec_nodes)
init_prec_nodes ();
if (!used_assoc)
init_assoc ();
for (i = 0; i < nsyms; ++i)
{
symbol *s = symbols[i];
if (is_assoc_useless (s))
complain (&s->location, Wother,
_("useless associativity for %s"), s->tag);
if (s
&& s->prec != 0
&& !prec_nodes[i]->pred
&& !prec_nodes[i]->succ)
{
if (is_assoc_useless (s))
complain (&s->location, Wprecedence,
_("useless precedence and associativity for %s"), s->tag);
else if (s->assoc == precedence_assoc)
complain (&s->location, Wprecedence,
_("useless precedence for %s"), s->tag);
}
else if (is_assoc_useless (s))
complain (&s->location, Wprecedence,
_("useless associativity for %s, use %%precedence"), s->tag);
}
}