Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-15 15:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

java: fixes in SymbolType

Browse Source 
Reported by Paolo Bonzini.
https://github.com/akimd/bison/pull/34#issuecomment-609029634

* data/skeletons/java.m4 (SymbolType): Use 'final' where possible.
(get): Rewrite on top of an array instead of a switch.
This commit is contained in:
Akim Demaille
2020-04-04 17:11:02 +02:00
parent ad31c3cdf4
commit f6dcecb287
1 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
data/skeletons/java.m4
View File

@@ -163,10 +163,6 @@ m4_define([b4_symbol_enum],
b4_symbol([$1], [number]))])]) b4_symbol([$1], [number]))])])
m4_define([b4_case_code_symbol],
[[ case $1: return SymbolType.]b4_symbol([$1], [sid]);
])
# b4_declare_symbol_enum # b4_declare_symbol_enum
# ---------------------- # ----------------------
# The definition of the symbol internal numbers as an enum. # The definition of the symbol internal numbers as an enum.
@@ -176,22 +172,25 @@ m4_define([b4_declare_symbol_enum],
]m4_join([, ]m4_join([,
], ],
]b4_symbol_sid([-2])[(-2), ]b4_symbol_sid([-2])[(-2),
b4_symbol_map([b4_symbol_enum]), b4_symbol_map([b4_symbol_enum]))[;
[YYNTOKENS(]b4_tokens_number[); ///< Number of tokens.])[
private int code; private final int code_;
SymbolType (int n) { SymbolType (int n) {
this.code = n; this.code_ = n;
} }
static SymbolType get (int code) {
switch (code) { private static final SymbolType[] values_ = {
default: return YYSYMBOL_YYUNDEF; ]m4_map_args_sep([b4_symbol_sid(], [)], [,
]b4_symbol_foreach([b4_case_code_symbol])[ ], b4_symbol_numbers)[
} };
static final SymbolType get (int code) {
return values_[code];
} }
int getCode () {
return this.code; public final int getCode () {
return this.code_;
} }
}; };
]])]) ]])])