Future/bison
1
0
Fork 0
mirror of https://git.savannah.gnu.org/git/bison.git synced 2026-03-17 00:03:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

glr2.cc: fix memory leak

Browse Source 
* data/skeletons/glr2.cc (glr_stack_item::setState): Free the previous
state before installing the new one.
This commit is contained in:
Akim Demaille
2021-01-09 17:57:32 +01:00
parent 3bcc090758
commit fbdff2bc38
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
data/skeletons/glr2.cc
View File

@@ -1374,10 +1374,10 @@ public:
~glr_stack_item () ~glr_stack_item ()
{]b4_parse_assert_if([[ {]b4_parse_assert_if([[
check_ ();]])[ check_ ();]])[
if (is_state()) if (is_state ())
getState().~glr_state(); getState ().~glr_state ();
else else
getOption().~semantic_option(); getOption ().~semantic_option ();
} }
void setState (const glr_state &state) void setState (const glr_state &state)
@@ -1386,12 +1386,12 @@ public:
state.check_ ();]])[ state.check_ ();]])[
if (this != state.asItem ()) if (this != state.asItem ())
{ {
is_state_ = true; if (is_state_)
// FIXME: What about the previous content? Shouldn't it be getState ().~glr_state ();
// freed? It might be useful to have an explicit "void" state else
// when this item is in unused state (in the list of free getOption ().~semantic_option ();
// items), when parse.assert is set.
new (&raw_) glr_state (state); new (&raw_) glr_state (state);
is_state_ = true;
} }
} }