mirror of
https://git.savannah.gnu.org/git/bison.git
synced 2026-03-09 12:23:04 +00:00
changed to use xcalloc, xnmalloc, xnrealloc, respectively, unless otherwise specified below. * src/LR0.c (allocate_itemsets): Use xnmalloc, not xcalloc, to allocate kernel_base, kernel_items, kernel_size, since they needn't be initialized to 0. (allocate_storgae): Likewise, for shiftset, redset, shift_symbol. * src/closure.c (new_closure): Likewise, for itemset. * src/derives.c (derives_compute): Likewise, for delts, derives, q. * src/lalr.c (set_goto_map): Likewise, for temp_map. (initialize_F): Likewise, for reads, edge, reads[i], includes[i]. (build_relations): Likewise for edge, states1, includes. * src/nullable.c (nullable_compute): Likewise, for squeue, relts. * src/reader.c (packgram): Likewise, for ritem, rules. * src/reduce.c (nonterminals_reduce): Likewise for nontermmap. * src/relation.c (relation_digraph): Likewise for VERTICES. (relation_transpose): Likewise for new_R, end_R. * src/symtab.c (symbols_token_translations_init): Likewise for token_translations. * src/tables.c (save_row): Likewise for froms, tos, conflict_tos. (token_actions): Likewise for yydefact, actrow, conflrow, conflict_list. (save_column): Likewise for froms[symno], tos[symno]. (goto_actions): Likewise for state_count. (pack_table): Likewise for base, pos, check. (tables_generate): Likewise for width. * src/LR0.c (set_states): Don't reuse kernel_size and kernel_base for initial core. Just have a separate core, so we needn't worry about whether kernel_size and kernel_base are initialized. * src/LR0.c (shift_symbol, redset, shiftset, kernel_base, kernel_size, kernel_items): Remove unnecessary initialization. * src/conflicts.c (conflicts): Likewise. * src/derives.c (derives): Likewise. * src/muscle_tablc (muscle_insert): Likewise. * src/relation.c (relation_digraph): Likewise. * src/tables.c (froms, tos, conflict_tos, tally, width, actrow, order, conflrow, conflict_table, conflict_list, table, check): Likewise. * src/closure.c (new_closure): Arg is of type unsigned int, not int. This is because all callers pass unsigned int. * src/closure.h (new_closure): Likewise. * src/lalr.c (initialize_F): Initialize reads[i] in all cases. (build_relations): Initialize includes[i] in all cases. * src/reader.c (packgram): Always initialize rules[ruleno].prec and rules[ruleno].precsym. Initialize members in order. * src/relation.c (relation_transpose): Always initialize new_R[i] and end_R[i]. * src/table.c (conflict_row): Initialize 0 at end of conflict_list. * src/output.c (prepare_actions): Pass 0 instead of conflict_list[0]; conflict_list[0] was always 0, but now it isn't initialized. * src/table.c (table_grow): When conflict_table grew, the grown area wasn't cleared. Fix this.
530 lines
15 KiB
C
530 lines
15 KiB
C
/* Find and resolve or report look-ahead conflicts for bison,
|
||
|
||
Copyright (C) 1984, 1989, 1992, 2000, 2001, 2002, 2003, 2004
|
||
Free Software Foundation, Inc.
|
||
|
||
This file is part of Bison, the GNU Compiler Compiler.
|
||
|
||
Bison is free software; you can redistribute it and/or modify it
|
||
under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 2, or (at your option)
|
||
any later version.
|
||
|
||
Bison is distributed in the hope that it will be useful, but
|
||
WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
||
General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with Bison; see the file COPYING. If not, write to the Free
|
||
Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
||
02111-1307, USA. */
|
||
|
||
#include "system.h"
|
||
|
||
#include <bitset.h>
|
||
|
||
#include "LR0.h"
|
||
#include "complain.h"
|
||
#include "conflicts.h"
|
||
#include "files.h"
|
||
#include "getargs.h"
|
||
#include "gram.h"
|
||
#include "lalr.h"
|
||
#include "reader.h"
|
||
#include "state.h"
|
||
#include "symtab.h"
|
||
|
||
/* -1 stands for not specified. */
|
||
int expected_sr_conflicts = -1;
|
||
int expected_rr_conflicts = -1;
|
||
static char *conflicts;
|
||
struct obstack solved_conflicts_obstack;
|
||
|
||
static bitset shift_set;
|
||
static bitset look_ahead_set;
|
||
|
||
|
||
|
||
enum conflict_resolution
|
||
{
|
||
shift_resolution,
|
||
reduce_resolution,
|
||
left_resolution,
|
||
right_resolution,
|
||
nonassoc_resolution
|
||
};
|
||
|
||
|
||
/*----------------------------------------------------------------.
|
||
| Explain how an SR conflict between TOKEN and RULE was resolved: |
|
||
| RESOLUTION. |
|
||
`----------------------------------------------------------------*/
|
||
|
||
static inline void
|
||
log_resolution (rule *r, symbol_number token,
|
||
enum conflict_resolution resolution)
|
||
{
|
||
if (report_flag & report_solved_conflicts)
|
||
{
|
||
/* The description of the resolution. */
|
||
switch (resolution)
|
||
{
|
||
case shift_resolution:
|
||
case right_resolution:
|
||
obstack_fgrow2 (&solved_conflicts_obstack,
|
||
_("\
|
||
Conflict between rule %d and token %s resolved as shift"),
|
||
r->number,
|
||
symbols[token]->tag);
|
||
break;
|
||
case reduce_resolution:
|
||
case left_resolution:
|
||
obstack_fgrow2 (&solved_conflicts_obstack,
|
||
_("\
|
||
Conflict between rule %d and token %s resolved as reduce"),
|
||
r->number,
|
||
symbols[token]->tag);
|
||
break;
|
||
case nonassoc_resolution:
|
||
obstack_fgrow2 (&solved_conflicts_obstack,
|
||
_("\
|
||
Conflict between rule %d and token %s resolved as an error"),
|
||
r->number,
|
||
symbols[token]->tag);
|
||
break;
|
||
}
|
||
|
||
/* The reason. */
|
||
switch (resolution)
|
||
{
|
||
case shift_resolution:
|
||
obstack_fgrow2 (&solved_conflicts_obstack,
|
||
" (%s < %s)",
|
||
r->prec->tag,
|
||
symbols[token]->tag);
|
||
break;
|
||
|
||
case reduce_resolution:
|
||
obstack_fgrow2 (&solved_conflicts_obstack,
|
||
" (%s < %s)",
|
||
symbols[token]->tag,
|
||
r->prec->tag);
|
||
break;
|
||
|
||
case left_resolution:
|
||
obstack_fgrow1 (&solved_conflicts_obstack,
|
||
" (%%left %s)",
|
||
symbols[token]->tag);
|
||
break;
|
||
|
||
case right_resolution:
|
||
obstack_fgrow1 (&solved_conflicts_obstack,
|
||
" (%%right %s)",
|
||
symbols[token]->tag);
|
||
break;
|
||
case nonassoc_resolution:
|
||
obstack_fgrow1 (&solved_conflicts_obstack,
|
||
" (%%nonassoc %s)",
|
||
symbols[token]->tag);
|
||
break;
|
||
}
|
||
obstack_sgrow (&solved_conflicts_obstack, ".\n");
|
||
}
|
||
}
|
||
|
||
|
||
/*------------------------------------------------------------------.
|
||
| Turn off the shift recorded for the specified token in the |
|
||
| specified state. Used when we resolve a shift-reduce conflict in |
|
||
| favor of the reduction. |
|
||
`------------------------------------------------------------------*/
|
||
|
||
static void
|
||
flush_shift (state *s, int token)
|
||
{
|
||
transitions *trans = s->transitions;
|
||
int i;
|
||
|
||
bitset_reset (look_ahead_set, token);
|
||
for (i = 0; i < trans->num; i++)
|
||
if (!TRANSITION_IS_DISABLED (trans, i)
|
||
&& TRANSITION_SYMBOL (trans, i) == token)
|
||
TRANSITION_DISABLE (trans, i);
|
||
}
|
||
|
||
|
||
/*--------------------------------------------------------------------.
|
||
| Turn off the reduce recorded for the specified token for the |
|
||
| specified look-ahead. Used when we resolve a shift-reduce conflict |
|
||
| in favor of the shift. |
|
||
`--------------------------------------------------------------------*/
|
||
|
||
static void
|
||
flush_reduce (bitset look_ahead_tokens, int token)
|
||
{
|
||
bitset_reset (look_ahead_tokens, token);
|
||
}
|
||
|
||
|
||
/*------------------------------------------------------------------.
|
||
| Attempt to resolve shift-reduce conflict for one rule by means of |
|
||
| precedence declarations. It has already been checked that the |
|
||
| rule has a precedence. A conflict is resolved by modifying the |
|
||
| shift or reduce tables so that there is no longer a conflict. |
|
||
| |
|
||
| RULENO is the number of the look-ahead bitset to consider. |
|
||
| |
|
||
| ERRORS can be used to store discovered explicit errors. |
|
||
`------------------------------------------------------------------*/
|
||
|
||
static void
|
||
resolve_sr_conflict (state *s, int ruleno, symbol **errors)
|
||
{
|
||
symbol_number i;
|
||
reductions *reds = s->reductions;
|
||
/* Find the rule to reduce by to get precedence of reduction. */
|
||
rule *redrule = reds->rules[ruleno];
|
||
int redprec = redrule->prec->prec;
|
||
bitset look_ahead_tokens = reds->look_ahead_tokens[ruleno];
|
||
int nerrs = 0;
|
||
|
||
for (i = 0; i < ntokens; i++)
|
||
if (bitset_test (look_ahead_tokens, i)
|
||
&& bitset_test (look_ahead_set, i)
|
||
&& symbols[i]->prec)
|
||
{
|
||
/* Shift-reduce conflict occurs for token number i
|
||
and it has a precedence.
|
||
The precedence of shifting is that of token i. */
|
||
if (symbols[i]->prec < redprec)
|
||
{
|
||
log_resolution (redrule, i, reduce_resolution);
|
||
flush_shift (s, i);
|
||
}
|
||
else if (symbols[i]->prec > redprec)
|
||
{
|
||
log_resolution (redrule, i, shift_resolution);
|
||
flush_reduce (look_ahead_tokens, i);
|
||
}
|
||
else
|
||
/* Matching precedence levels.
|
||
For left association, keep only the reduction.
|
||
For right association, keep only the shift.
|
||
For nonassociation, keep neither. */
|
||
|
||
switch (symbols[i]->assoc)
|
||
{
|
||
case right_assoc:
|
||
log_resolution (redrule, i, right_resolution);
|
||
flush_reduce (look_ahead_tokens, i);
|
||
break;
|
||
|
||
case left_assoc:
|
||
log_resolution (redrule, i, left_resolution);
|
||
flush_shift (s, i);
|
||
break;
|
||
|
||
case non_assoc:
|
||
log_resolution (redrule, i, nonassoc_resolution);
|
||
flush_shift (s, i);
|
||
flush_reduce (look_ahead_tokens, i);
|
||
/* Record an explicit error for this token. */
|
||
errors[nerrs++] = symbols[i];
|
||
break;
|
||
|
||
case undef_assoc:
|
||
abort ();
|
||
}
|
||
}
|
||
|
||
if (nerrs)
|
||
{
|
||
/* Some tokens have been explicitly made errors. Allocate a
|
||
permanent errs structure for this state, to record them. */
|
||
state_errs_set (s, nerrs, errors);
|
||
}
|
||
|
||
if (obstack_object_size (&solved_conflicts_obstack))
|
||
{
|
||
obstack_1grow (&solved_conflicts_obstack, '\0');
|
||
s->solved_conflicts = obstack_finish (&solved_conflicts_obstack);
|
||
}
|
||
}
|
||
|
||
|
||
/*-------------------------------------------------------------------.
|
||
| Solve the S/R conflicts of state S using the |
|
||
| precedence/associativity, and flag it inconsistent if it still has |
|
||
| conflicts. ERRORS can be used as storage to compute the list of |
|
||
| look-ahead tokens on which S raises a syntax error (%nonassoc). |
|
||
`-------------------------------------------------------------------*/
|
||
|
||
static void
|
||
set_conflicts (state *s, symbol **errors)
|
||
{
|
||
int i;
|
||
transitions *trans = s->transitions;
|
||
reductions *reds = s->reductions;
|
||
|
||
if (s->consistent)
|
||
return;
|
||
|
||
bitset_zero (look_ahead_set);
|
||
|
||
FOR_EACH_SHIFT (trans, i)
|
||
bitset_set (look_ahead_set, TRANSITION_SYMBOL (trans, i));
|
||
|
||
/* Loop over all rules which require look-ahead in this state. First
|
||
check for shift-reduce conflict, and try to resolve using
|
||
precedence. */
|
||
for (i = 0; i < reds->num; ++i)
|
||
if (reds->rules[i]->prec && reds->rules[i]->prec->prec
|
||
&& !bitset_disjoint_p (reds->look_ahead_tokens[i], look_ahead_set))
|
||
resolve_sr_conflict (s, i, errors);
|
||
|
||
/* Loop over all rules which require look-ahead in this state. Check
|
||
for conflicts not resolved above. */
|
||
for (i = 0; i < reds->num; ++i)
|
||
{
|
||
if (!bitset_disjoint_p (reds->look_ahead_tokens[i], look_ahead_set))
|
||
conflicts[s->number] = 1;
|
||
|
||
bitset_or (look_ahead_set, look_ahead_set, reds->look_ahead_tokens[i]);
|
||
}
|
||
}
|
||
|
||
|
||
/*----------------------------------------------------------------.
|
||
| Solve all the S/R conflicts using the precedence/associativity, |
|
||
| and flag as inconsistent the states that still have conflicts. |
|
||
`----------------------------------------------------------------*/
|
||
|
||
void
|
||
conflicts_solve (void)
|
||
{
|
||
state_number i;
|
||
/* List of look-ahead tokens on which we explicitly raise a syntax error. */
|
||
symbol **errors = xnmalloc (ntokens + 1, sizeof *errors);
|
||
|
||
conflicts = xcalloc (nstates, sizeof *conflicts);
|
||
shift_set = bitset_create (ntokens, BITSET_FIXED);
|
||
look_ahead_set = bitset_create (ntokens, BITSET_FIXED);
|
||
obstack_init (&solved_conflicts_obstack);
|
||
|
||
for (i = 0; i < nstates; i++)
|
||
{
|
||
set_conflicts (states[i], errors);
|
||
|
||
/* For uniformity of the code, make sure all the states have a valid
|
||
`errs' member. */
|
||
if (!states[i]->errs)
|
||
states[i]->errs = errs_new (0, 0);
|
||
}
|
||
|
||
free (errors);
|
||
}
|
||
|
||
|
||
/*---------------------------------------------.
|
||
| Count the number of shift/reduce conflicts. |
|
||
`---------------------------------------------*/
|
||
|
||
static int
|
||
count_sr_conflicts (state *s)
|
||
{
|
||
int i;
|
||
int src_count = 0;
|
||
transitions *trans = s->transitions;
|
||
reductions *reds = s->reductions;
|
||
|
||
if (!trans)
|
||
return 0;
|
||
|
||
bitset_zero (look_ahead_set);
|
||
bitset_zero (shift_set);
|
||
|
||
FOR_EACH_SHIFT (trans, i)
|
||
bitset_set (shift_set, TRANSITION_SYMBOL (trans, i));
|
||
|
||
for (i = 0; i < reds->num; ++i)
|
||
bitset_or (look_ahead_set, look_ahead_set, reds->look_ahead_tokens[i]);
|
||
|
||
bitset_and (look_ahead_set, look_ahead_set, shift_set);
|
||
|
||
src_count = bitset_count (look_ahead_set);
|
||
|
||
return src_count;
|
||
}
|
||
|
||
|
||
/*----------------------------------------------------------------.
|
||
| Count the number of reduce/reduce conflicts. If ONE_PER_TOKEN, |
|
||
| count one conflict for each token that has any reduce/reduce |
|
||
| conflicts. Otherwise, count one conflict for each pair of |
|
||
| conflicting reductions. |
|
||
+`----------------------------------------------------------------*/
|
||
|
||
static int
|
||
count_rr_conflicts (state *s, bool one_per_token)
|
||
{
|
||
int i;
|
||
reductions *reds = s->reductions;
|
||
int rrc_count = 0;
|
||
|
||
for (i = 0; i < ntokens; i++)
|
||
{
|
||
int count = 0;
|
||
int j;
|
||
for (j = 0; j < reds->num; ++j)
|
||
if (bitset_test (reds->look_ahead_tokens[j], i))
|
||
count++;
|
||
|
||
if (count >= 2)
|
||
rrc_count += one_per_token ? 1 : count-1;
|
||
}
|
||
|
||
return rrc_count;
|
||
}
|
||
|
||
|
||
/*--------------------------------------------------------.
|
||
| Report the number of conflicts, using the Yacc format. |
|
||
`--------------------------------------------------------*/
|
||
|
||
static void
|
||
conflict_report (FILE *out, int src_num, int rrc_num)
|
||
{
|
||
if (src_num && rrc_num)
|
||
fprintf (out, _("conflicts: %d shift/reduce, %d reduce/reduce\n"),
|
||
src_num, rrc_num);
|
||
else if (src_num)
|
||
fprintf (out, _("conflicts: %d shift/reduce\n"), src_num);
|
||
else if (rrc_num)
|
||
fprintf (out, _("conflicts: %d reduce/reduce\n"), rrc_num);
|
||
}
|
||
|
||
|
||
/*-----------------------------------------------------------.
|
||
| Output the detailed description of states with conflicts. |
|
||
`-----------------------------------------------------------*/
|
||
|
||
void
|
||
conflicts_output (FILE *out)
|
||
{
|
||
bool printed_sth = false;
|
||
state_number i;
|
||
for (i = 0; i < nstates; i++)
|
||
{
|
||
state *s = states[i];
|
||
if (conflicts[i])
|
||
{
|
||
fprintf (out, _("State %d "), i);
|
||
conflict_report (out, count_sr_conflicts (s),
|
||
count_rr_conflicts (s, true));
|
||
printed_sth = true;
|
||
}
|
||
}
|
||
if (printed_sth)
|
||
fputs ("\n\n", out);
|
||
}
|
||
|
||
/*--------------------------------------------------------.
|
||
| Total the number of S/R and R/R conflicts. Unlike the |
|
||
| code in conflicts_output, however, count EACH pair of |
|
||
| reductions for the same state and look-ahead as one |
|
||
| conflict. |
|
||
`--------------------------------------------------------*/
|
||
|
||
int
|
||
conflicts_total_count (void)
|
||
{
|
||
state_number i;
|
||
int count;
|
||
|
||
/* Conflicts by state. */
|
||
count = 0;
|
||
for (i = 0; i < nstates; i++)
|
||
if (conflicts[i])
|
||
{
|
||
count += count_sr_conflicts (states[i]);
|
||
count += count_rr_conflicts (states[i], false);
|
||
}
|
||
return count;
|
||
}
|
||
|
||
|
||
/*------------------------------------------.
|
||
| Reporting the total number of conflicts. |
|
||
`------------------------------------------*/
|
||
|
||
void
|
||
conflicts_print (void)
|
||
{
|
||
/* Is the number of SR conflicts OK? Either EXPECTED_CONFLICTS is
|
||
not set, and then we want 0 SR, or else it is specified, in which
|
||
case we want equality. */
|
||
bool src_ok = false;
|
||
bool rrc_ok = false;
|
||
|
||
int src_total = 0;
|
||
int rrc_total = 0;
|
||
|
||
/* Conflicts by state. */
|
||
{
|
||
state_number i;
|
||
|
||
for (i = 0; i < nstates; i++)
|
||
if (conflicts[i])
|
||
{
|
||
src_total += count_sr_conflicts (states[i]);
|
||
rrc_total += count_rr_conflicts (states[i], true);
|
||
}
|
||
}
|
||
|
||
if (! glr_parser && rrc_total > 0 && expected_rr_conflicts != -1)
|
||
{
|
||
warn (_("%%expect-rr applies only to GLR parsers"));
|
||
expected_rr_conflicts = -1;
|
||
}
|
||
|
||
src_ok =
|
||
src_total == (expected_sr_conflicts == -1 ? 0 : expected_sr_conflicts);
|
||
rrc_ok =
|
||
rrc_total == (expected_rr_conflicts == -1 ? 0 : expected_rr_conflicts);
|
||
|
||
/* If there are as many RR conflicts and SR conflicts as
|
||
expected, then there is nothing to report. */
|
||
if (rrc_ok && src_ok)
|
||
return;
|
||
|
||
/* Report the total number of conflicts on STDERR. */
|
||
if (! yacc_flag)
|
||
fprintf (stderr, "%s: ", current_file);
|
||
conflict_report (stderr, src_total, rrc_total);
|
||
|
||
if (expected_sr_conflicts != -1 || expected_rr_conflicts != -1)
|
||
{
|
||
int sr = expected_sr_conflicts == -1 ? 0 : expected_sr_conflicts;
|
||
int rr = expected_rr_conflicts == -1 ? 0 : expected_rr_conflicts;
|
||
if (! src_ok)
|
||
warn (ngettext ("expected %d shift/reduce conflict",
|
||
"expected %d shift/reduce conflicts",
|
||
sr), sr);
|
||
if (! rrc_ok)
|
||
warn (ngettext ("expected %d reduce/reduce conflict",
|
||
"expected %d reduce/reduce conflicts",
|
||
rr), rr);
|
||
}
|
||
}
|
||
|
||
|
||
void
|
||
conflicts_free (void)
|
||
{
|
||
free (conflicts);
|
||
bitset_free (shift_set);
|
||
bitset_free (look_ahead_set);
|
||
obstack_free (&solved_conflicts_obstack, NULL);
|
||
}
|