mirror of
https://git.savannah.gnu.org/git/bison.git
synced 2026-03-09 20:33:03 +00:00
827bc59ca1
Bison supports a union tag, for obscure reasons. But it does a poor job at it, especially since Bison 3.0. Reported by Stephen Cameron and Tobias Frost. It did not ensure that the name was not given several times. An easy way to do this is to make the %union tag be handled as a %define variable, as they cannot be defined several times. Since Bison 3.0, the synclines were wrongly placed, resulting in invalid code. Addressing this issue, because of the way the union tag was stored (as a code muscle), would have been tedious. Unless we rather define the %union tag as a %percent variable, whose synclines are easier to manipulate. So replace the b4_union_name muscle by the api.value.union.name %define variable, document, and check. * data/bison.m4: Make sure that api.value.union.name has a keyword value. * data/c++.m4: Make sure that api.value.union.name is not defined. * data/c.m4 (b4_union_name): No longer use it, use api.value.union.name. * doc/bison.texi (%define Summary): Document it. * src/parse-gram.y (union_name): No longer define b4_uion_name, but api.value.union.name. * tests/input.at (Redefined %union name): New. * tests/synclines.at (%union name syncline): New. * tests/types.at: Check named %unions.
325 lines
6.6 KiB
Plaintext
325 lines
6.6 KiB
Plaintext
# Executing Actions. -*- Autotest -*-
|
|
|
|
# Copyright (C) 2002, 2004-2005, 2007, 2009-2015 Free Software
|
|
# Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
AT_BANNER([[User Actions.]])
|
|
|
|
|
|
# AT_SYNCLINES_COMPILE(FILE)
|
|
# --------------------------
|
|
# Compile FILE expecting an error, and save in the file stdout the
|
|
# normalized output. Ignore the exit status, since some compilers
|
|
# (e.g. c89 on IRIX 6.5) trigger warnings on '#error', instead of
|
|
# errors.
|
|
m4_define([AT_SYNCLINES_COMPILE],
|
|
[AT_CHECK([$CC $CFLAGS $CPPFLAGS -c $1], [ignore], [], [stderr])
|
|
|
|
# Transform stderr into something like this:
|
|
#
|
|
# input.y:4: #error "4"
|
|
#
|
|
# In case GCC displays column information, strip it down.
|
|
#
|
|
# input.y:4:2: #error "4" or
|
|
# input.y:4.2: #error "4" or
|
|
# input.y:4:2: error: #error "4"
|
|
# =>
|
|
# input.y:4: #error "4"
|
|
#
|
|
# It may also issue more context information:
|
|
#
|
|
# input.y: In function 'yyparse':
|
|
# input.y:8: #error "8"
|
|
# =>
|
|
# input.y:4: #error "8"
|
|
#
|
|
# The message may include a caret-error (indented by GCC 4.8,
|
|
# not by clang 3.2):
|
|
#
|
|
# input.y:1:2: error: #error "1"
|
|
# #error "1"
|
|
# ^
|
|
#
|
|
# Possibly distcc adds its bits.
|
|
#
|
|
# distcc[33187] ERROR: compile (null) on localhost failed
|
|
# syncline.c:1:2: error: #error "1"
|
|
# distcc[33185] ERROR: compile syncline.c on localhost failed
|
|
#
|
|
# or even
|
|
#
|
|
# distcc[35882] (dcc_connect_by_name) ERROR: failed to look up host "chrisimac": Unknown host
|
|
# distcc[35882] Warning: failed to distribute input.c to chrisimac/4, running locally instead
|
|
#
|
|
# The compiler might end by the number of messages issued (Clang 3.2):
|
|
#
|
|
# syncline.c:1:2: error: "1"
|
|
# #error "1"
|
|
# ^
|
|
# 1 error generated.
|
|
#
|
|
# When c++ is used to compiler C, we might have more messages (Clang 3.2):
|
|
#
|
|
# clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated
|
|
|
|
AT_CHECK([[$PERL -p -0777 - stderr <<\EOF
|
|
# 1. Remove useless lines.
|
|
|
|
# distcc clutter.
|
|
s/^distcc\[\d+\] .*\n//gm;
|
|
# c vs. c++.
|
|
s/^clang: warning: treating 'c' input as 'c\+\+'.*\n//gm;
|
|
# Function context.
|
|
s/^[^:]*: In function '[^']+':\n//gm;
|
|
# Caret error.
|
|
s/^ *#error.*\n *\^\n//gm;
|
|
# Number of errors.
|
|
s/^1 error generated\.\n//gm;
|
|
|
|
# 2. Normalize the lines we kept.
|
|
|
|
# Remove column.
|
|
s/^([^:]+:\d+)[.:][^:]+:(.+)$/$][1:$][2/gm;
|
|
# Map all combinations of "error: " and "#error: " to "#error ".
|
|
s/^([^:]+:\d+):( |#error|error|:)+/$][1: #error /gm;
|
|
EOF
|
|
]],
|
|
0, [stdout])
|
|
])
|
|
|
|
# AT_TEST(TITLE, INPUT, ERROR-MSG)
|
|
# --------------------------------
|
|
# Check that compiling the parser produced from INPUT cause GCC
|
|
# to issue ERROR-MSG.
|
|
m4_pushdef([AT_TEST],
|
|
[AT_SETUP([$1])
|
|
AT_BISON_OPTION_PUSHDEFS
|
|
# It seems impossible to find a generic scheme to check the location
|
|
# of an error. Even requiring GCC is not sufficient, since for instance
|
|
# the version modified by Apple:
|
|
#
|
|
# | Reading specs from /usr/libexec/gcc/darwin/ppc/2.95.2/specs
|
|
# | Apple Computer, Inc. version gcc-934.3, based on gcc version 2.95.2
|
|
# | 19991024 (release) configure:2124: $? = 0
|
|
#
|
|
# instead of:
|
|
#
|
|
# | input.y:2: #error "2"
|
|
#
|
|
# it reports:
|
|
#
|
|
# | input.y:2: "2"
|
|
# | cpp-precomp: warning: errors during smart preprocessing, retrying in basic mode
|
|
|
|
AT_DATA([syncline.c],
|
|
[[#error "1"
|
|
int i; /* avoids -pedantic warning about an empty translation unit. */
|
|
]])
|
|
|
|
AT_SYNCLINES_COMPILE([syncline.c])
|
|
AT_CHECK([[test "`cat stdout`" = 'syncline.c:1: @%:@error "1"' || exit 77]])
|
|
|
|
AT_DATA([[input.y]], [$2])
|
|
AT_BISON_CHECK([-o input.c input.y])
|
|
AT_SYNCLINES_COMPILE([input.c])
|
|
AT_CHECK([cat stdout], 0, [$3])
|
|
AT_BISON_OPTION_POPDEFS
|
|
AT_CLEANUP
|
|
])
|
|
|
|
|
|
## ------------------- ##
|
|
## Prologue syncline. ##
|
|
## ------------------- ##
|
|
|
|
|
|
AT_TEST([Prologue syncline],
|
|
[[%{
|
|
#error "2"
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
]],
|
|
[input.y:2: #error "2"
|
|
])
|
|
|
|
|
|
## ----------------- ##
|
|
## %union syncline. ##
|
|
## ----------------- ##
|
|
|
|
AT_TEST([%union syncline],
|
|
[[%union {
|
|
#error "2"
|
|
char dummy;
|
|
}
|
|
%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
]],
|
|
[input.y:2: #error "2"
|
|
])
|
|
|
|
|
|
## ---------------------- ##
|
|
## %union name syncline. ##
|
|
## ---------------------- ##
|
|
|
|
# Check that invalid union names are properly reported in the
|
|
# source file.
|
|
AT_SETUP([%union name syncline])
|
|
AT_BISON_OPTION_PUSHDEFS
|
|
AT_DATA([[input.y]],
|
|
[[%union break
|
|
{
|
|
char dummy;
|
|
}
|
|
%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
]])
|
|
|
|
AT_BISON_CHECK([-o input.c input.y])
|
|
AT_SYNCLINES_COMPILE([input.c])
|
|
AT_CHECK([[grep '^input.y:1' stdout]], 0, [ignore])
|
|
AT_BISON_OPTION_POPDEFS
|
|
AT_CLEANUP
|
|
|
|
|
|
## ----------------------- ##
|
|
## Postprologue syncline. ##
|
|
## ----------------------- ##
|
|
|
|
AT_TEST([Postprologue syncline],
|
|
[[%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%union
|
|
{
|
|
int ival;
|
|
}
|
|
%{
|
|
#error "10"
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
]],
|
|
[input.y:10: #error "10"
|
|
])
|
|
|
|
|
|
## ----------------- ##
|
|
## Action syncline. ##
|
|
## ----------------- ##
|
|
|
|
AT_TEST([Action syncline],
|
|
[[%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp:
|
|
{
|
|
#error "8"
|
|
};
|
|
]],
|
|
[input.y:8: #error "8"
|
|
])
|
|
|
|
|
|
## ------------------- ##
|
|
## Epilogue syncline. ##
|
|
## ------------------- ##
|
|
|
|
AT_TEST([Epilogue syncline],
|
|
[[%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
#error "8"
|
|
]],
|
|
[input.y:8: #error "8"
|
|
])
|
|
|
|
## -------------------- ##
|
|
## %code top syncline. ##
|
|
## -------------------- ##
|
|
|
|
AT_TEST([%code top syncline],
|
|
[[%code top {
|
|
#error "2"
|
|
}
|
|
%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0';
|
|
%%
|
|
]],
|
|
[input.y:2: #error "2"
|
|
])
|
|
|
|
m4_popdef([AT_TEST])
|
|
|
|
## ----------- ##
|
|
## %no-lines. ##
|
|
## ----------- ##
|
|
|
|
m4_pushdef([AT_TEST],
|
|
[AT_SETUP([%no-lines: $1])
|
|
|
|
AT_BISON_OPTION_PUSHDEFS([%skeleton "$1" %defines])
|
|
AT_DATA_GRAMMAR([input.y],
|
|
[%skeleton "$1" %defines
|
|
%{
|
|
]AT_YYERROR_DECLARE_EXTERN[
|
|
]AT_YYLEX_DECLARE_EXTERN[
|
|
%}
|
|
%%
|
|
exp: '0'
|
|
])
|
|
AT_BISON_CHECK([--no-lines -o input.AT_SKEL_CC_IF([cc], [c]) -d input.y])
|
|
AT_CHECK([[grep '#line' ]AT_SKEL_CC_IF([*.cc *.hh], [*.c *.h])], 1)
|
|
AT_BISON_OPTION_POPDEFS
|
|
|
|
AT_CLEANUP
|
|
])
|
|
|
|
AT_TEST([yacc.c])
|
|
AT_TEST([glr.c])
|
|
AT_TEST([lalr1.cc])
|
|
AT_TEST([glr.cc])
|
|
|
|
m4_popdef([AT_TEST])
|