mirror of
https://git.savannah.gnu.org/git/bison.git
synced 2026-07-23 09:50:32 +00:00
Joel E. Denny
f39ab2869c
M4's output pipe was not being drained upon fatal errors during
scan_skel. As a result, broken-pipe messages from M4 were seen
on at least AIX, HP-UX, Solaris, and RHEL4, and this caused a
failure in the test suite. The problem was that, on platforms
where the default disposition for SIGPIPE is ignore instead of
terminate, M4 sometimes saw fwrite fail with errno=EPIPE and
then reported it. However, there's some sort of race condition,
because the new test group occasionally succeeded.
Reported by Albert Chin at
<http://lists.gnu.org/archive/html/bug-bison/2010-02/msg00004.html>.
There were also problems with the test suite livelocking on
Tru64 5.1b. Reported by Didier Godefroy at
<http://lists.gnu.org/archive/html/bug-bison/2009-05/msg00005.html>.
Switching to create_pipe_bidi suggested by Akim Demaille.
To attempt to solve both of these problems, switch to gnulib's
create_pipe_bidi and register M4 process as a slave. Along the
way, clean up file name conflict handling, which was affected by
the broken-pipe problem before the switch.
* NEWS (2.4.2): Document.
* THANKS (Didier Godefroy): Add.
* bootstrap.conf (gnulib_modules): Add pipe.
* gnulib: Update to latest to make sure we have all the latest
fixes.
* lib/local.mk (lib_libbison_a_SOURCES): Remove subpipe.h and
subpipe.c.
* po/POTFILES.in (lib/subpipe.c): Remove.
* src/files.c (compute_output_file_names): Update invocations
of output_file_name_check.
(output_file_name_check): In the case that the grammar file
would be overwritten, use complain instead of fatal, but replace
the output file name with /dev/null. Use the /dev/null solution
for the case of two conflicting output files as well because it
seems safer in case Bison one day tries to open both files at
the same time.
* src/files.h (output_file_name_check): Update prototype.
* src/output.c (output_skeleton): Use create_pipe_bidi and
wait_subprocess. Assert that scan_skel completely drains the
pipe.
* src/scan-skel.l (at_directive_perform): Update
output_file_name_check invocation.
* tests/output.at (AT_CHECK_CONFLICTING_OUTPUT): Check that the
grammar file actually isn't overwritten.
(Conflicting output files: -o foo.y): Update expected output.
* tests/skeletons.at (Fatal errors but M4 continues producing
output): New test group.
(cherry picked from commit 22cc8d813e)
Conflicts:
NEWS
bootstrap.conf
lib/.cvsignore
lib/.gitignore
lib/Makefile.am
m4/.cvsignore
m4/.gitignore
src/output.c
115 lines
5.1 KiB
Plaintext
115 lines
5.1 KiB
Plaintext
Bison was originally written by Robert Corbett. It would not be what
|
|
it is today without the invaluable help of these people:
|
|
|
|
Airy Andre [email protected]
|
|
Akim Demaille [email protected]
|
|
Albert Chin-A-Young [email protected]
|
|
Alexander Belopolsky [email protected]
|
|
Alexandre Duret-Lutz [email protected]
|
|
Andreas Schwab [email protected]
|
|
Andrew Suffield [email protected]
|
|
Anthony Heading [email protected]
|
|
Arnold Robbins [email protected]
|
|
Art Haas [email protected]
|
|
Baron Schwartz [email protected]
|
|
Benoit Perrot [email protected]
|
|
Bert Deknuydt [email protected]
|
|
Bill Allombert [email protected]
|
|
Bob Rossi [email protected]
|
|
Brandon Lucia [email protected]
|
|
Bruce Lilly [email protected]
|
|
Bruno Haible [email protected]
|
|
Charles-Henri de Boysson [email protected]
|
|
Christian Burger [email protected]
|
|
Cris Bailiff [email protected]
|
|
Cris van Pelt [email protected]
|
|
Csaba Raduly [email protected]
|
|
Daniel Hagerty [email protected]
|
|
David J. MacKenzie [email protected]
|
|
Derek M. Jones [email protected]
|
|
Di-an Jan [email protected]
|
|
Dick Streefland [email protected]
|
|
Didier Godefroy [email protected]
|
|
Enrico Scholz [email protected]
|
|
Eric Blake [email protected]
|
|
Evgeny Stambulchik [email protected]
|
|
Fabrice Bauzac [email protected]
|
|
Florian Krohm [email protected]
|
|
Frank Heckenbach [email protected]
|
|
Frans Englich [email protected]
|
|
Georg Sauthoff [email protected]
|
|
Goran Uddeborg [email protected]
|
|
Guido Trentalancia [email protected]
|
|
H. Merijn Brand [email protected]
|
|
Hans Aberg [email protected]
|
|
Jan Nieuwenhuizen [email protected]
|
|
Jesse Thilo [email protected]
|
|
Jim Kent [email protected]
|
|
Jim Meyering [email protected]
|
|
Joel E. Denny [email protected]
|
|
Jonathan Nieder [email protected]
|
|
Juan Manuel Guerrero [email protected]
|
|
Kees Zeelenberg [email protected]
|
|
Keith Browne [email protected]
|
|
Laurent Mascherpa [email protected]
|
|
Magnus Fromreide [email protected]
|
|
Marc Autret [email protected]
|
|
Martin Jacobs [email protected]
|
|
Martin Mokrejs [email protected]
|
|
Martin Nylin [email protected]
|
|
Matt Kraai [email protected]
|
|
Matt Rosing [email protected]
|
|
Michael Hayes [email protected]
|
|
Michael Raskin [email protected]
|
|
Michiel De Wilde [email protected]
|
|
Mickael Labau [email protected]
|
|
Mike Castle [email protected]
|
|
Neil Booth [email protected]
|
|
Nelson H. F. Beebe [email protected]
|
|
Nicolas Burrus [email protected]
|
|
Nicolas Tisserand [email protected]
|
|
Noah Friedman [email protected]
|
|
Odd Arild Olsen [email protected]
|
|
Oleg Smolsky [email protected]
|
|
Paolo Bonzini [email protected]
|
|
Pascal Bart [email protected]
|
|
Paul Eggert [email protected]
|
|
Paul Hilfinger [email protected]
|
|
Per Allansson [email protected]
|
|
Peter Fales [email protected]
|
|
Peter Hamorsky [email protected]
|
|
Piotr Gackiewicz [email protected]
|
|
Quentin Hocquet [email protected]
|
|
Quoc Peyrot [email protected]
|
|
R Blake [email protected]
|
|
Raja R Harinath [email protected]
|
|
Ralf Wildenhues [email protected]
|
|
Richard Stallman [email protected]
|
|
Robert Anisko [email protected]
|
|
Satya Kiran Popuri [email protected]
|
|
Sebastian Setzer [email protected]
|
|
Sebastien Fricker [email protected]
|
|
Sergei Steshenko [email protected]
|
|
Shura [email protected]
|
|
Steve Murphy [email protected]
|
|
Summum Bonum [email protected]
|
|
Tim Josling [email protected]
|
|
Tim Van Holder [email protected]
|
|
Tom Lane [email protected]
|
|
Tom Tromey [email protected]
|
|
Tommy Nordgren [email protected]
|
|
Troy A. Johnson [email protected]
|
|
Tys Lefering [email protected]
|
|
Vin Shelton [email protected]
|
|
Wayne Green [email protected]
|
|
Wolfram Wagner [email protected]
|
|
Wwp [email protected]
|
|
Zack Weinberg [email protected]
|
|
|
|
Many people are not named here because we lost track of them. We
|
|
thank them! Please, help us keeping this list up to date.
|
|
|
|
Local Variables:
|
|
mode: text
|
|
End:
|