mirror of
https://git.savannah.gnu.org/git/bison.git
synced 2026-03-10 12:53:03 +00:00
22cc8d813e
M4's output pipe was not being drained upon fatal errors during scan_skel. As a result, broken-pipe messages from M4 were seen on at least AIX, HP-UX, Solaris, and RHEL4, and this caused a failure in the test suite. The problem was that, on platforms where the default disposition for SIGPIPE is ignore instead of terminate, M4 sometimes saw fwrite fail with errno=EPIPE and then reported it. However, there's some sort of race condition, because the new test group occasionally succeeded. Reported by Albert Chin at <http://lists.gnu.org/archive/html/bug-bison/2010-02/msg00004.html>. There were also problems with the test suite livelocking on Tru64 5.1b. Reported by Didier Godefroy at <http://lists.gnu.org/archive/html/bug-bison/2009-05/msg00005.html>. Switching to create_pipe_bidi suggested by Akim Demaille. To attempt to solve both of these problems, switch to gnulib's create_pipe_bidi and register M4 process as a slave. Along the way, clean up file name conflict handling, which was affected by the broken-pipe problem before the switch. * NEWS (2.4.2): Document. * THANKS (Didier Godefroy): Add. * bootstrap.conf (gnulib_modules): Add pipe. * gnulib: Update to latest to make sure we have all the latest fixes. * lib/Makefile.am (libbison_a_SOURCES): Remove subpipe.h and subpipe.c. * po/POTFILES.in (lib/subpipe.c): Remove. * src/files.c (compute_output_file_names): Update invocations of output_file_name_check. (output_file_name_check): In the case that the grammar file would be overwritten, use complain instead of fatal, but replace the output file name with /dev/null. Use the /dev/null solution for the case of two conflicting output files as well because it seems safer in case Bison one day tries to open both files at the same time. * src/files.h (output_file_name_check): Update prototype. * src/output.c (output_skeleton): Use create_pipe_bidi and wait_subprocess. Assert that scan_skel completely drains the pipe. * src/scan-skel.l (at_directive_perform): Update output_file_name_check invocation. * tests/output.at (AT_CHECK_CONFLICTING_OUTPUT): Check that the grammar file actually isn't overwritten. (Conflicting output files: -o foo.y): Update expected output. * tests/skeletons.at (Fatal errors but M4 continues producing output): New test group.
109 lines
1.4 KiB
Plaintext
109 lines
1.4 KiB
Plaintext
/00gnulib.m4
|
|
/absolute-header.m4
|
|
/alloca.m4
|
|
/argmatch.m4
|
|
/assert.m4
|
|
/cloexec.m4
|
|
/config-h.m4
|
|
/dirname.m4
|
|
/dos.m4
|
|
/double-slash-root.m4
|
|
/dup2.m4
|
|
/environ.m4
|
|
/errno_h.m4
|
|
/error.m4
|
|
/exitfail.m4
|
|
/extensions.m4
|
|
/fatal-signal.m4
|
|
/fcntl-o.m4
|
|
/fcntl.m4
|
|
/fcntl_h.m4
|
|
/fopen.m4
|
|
/getdtablesize.m4
|
|
/getopt.m4
|
|
/getpagesize.m4
|
|
/gettext.m4
|
|
/gnulib-cache.m4
|
|
/gnulib-common.m4
|
|
/gnulib-comp.m4
|
|
/gnulib-tool.m4
|
|
/hash.m4
|
|
/iconv.m4
|
|
/include_next.m4
|
|
/inline.m4
|
|
/intlmacosx.m4
|
|
/inttypes-h.m4
|
|
/inttypes-pri.m4
|
|
/inttypes.m4
|
|
/javacomp.m4
|
|
/javaexec.m4
|
|
/lib-ld.m4
|
|
/lib-link.m4
|
|
/lib-prefix.m4
|
|
/localcharset.m4
|
|
/locale-fr.m4
|
|
/locale-ja.m4
|
|
/locale-zh.m4
|
|
/longlong.m4
|
|
/malloc.m4
|
|
/mbrtowc.m4
|
|
/mbsinit.m4
|
|
/mbstate_t.m4
|
|
/mbswidth.m4
|
|
/memchr.m4
|
|
/mmap-anon.m4
|
|
/mode_t.m4
|
|
/multiarch.m4
|
|
/nls.m4
|
|
/open.m4
|
|
/pipe.m4
|
|
/pipe2.m4
|
|
/po.m4
|
|
/posix_spawn.m4
|
|
/progtest.m4
|
|
/quote.m4
|
|
/quotearg.m4
|
|
/rawmemchr.m4
|
|
/sched_h.m4
|
|
/setenv.m4
|
|
/sig_atomic_t.m4
|
|
/sigaction.m4
|
|
/signal_h.m4
|
|
/signalblocking.m4
|
|
/spawn_h.m4
|
|
/stat.m4
|
|
/stdbool.m4
|
|
/stddef_h.m4
|
|
/stdint.m4
|
|
/stdint_h.m4
|
|
/stdio-safer.m4
|
|
/stdio_h.m4
|
|
/stdlib_h.m4
|
|
/stpcpy.m4
|
|
/strchrnul.m4
|
|
/strerror.m4
|
|
/string_h.m4
|
|
/strndup.m4
|
|
/strnlen.m4
|
|
/strtol.m4
|
|
/strtoul.m4
|
|
/strverscmp.m4
|
|
/sys_stat_h.m4
|
|
/sys_wait_h.m4
|
|
/threadlib.m4
|
|
/time_h.m4
|
|
/unistd-safer.m4
|
|
/unistd_h.m4
|
|
/unlocked-io.m4
|
|
/wait-process.m4
|
|
/warn-on-use.m4
|
|
/warning.m4
|
|
/warnings.m4
|
|
/wchar.m4
|
|
/wchar_t.m4
|
|
/wctype.m4
|
|
/wcwidth.m4
|
|
/wint_t.m4
|
|
/xalloc.m4
|
|
/xstrndup.m4
|