Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some Mobile code labeling and removed magic numbers (#993)

Browse Source 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
This commit is contained in:
Andrew Cook
2022-09-15 10:49:58 +10:00
committed by GitHub
parent 41d5ea0482
commit 0f5540740b
19 changed files with 536 additions and 468 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mobile/mobile_40.asm
View File

@@ -2453,10 +2453,10 @@ endr
ld [hl], e
inc hl
ld [hl], d
ld a, $07
ld a, BANK(s7_a001)
call OpenSRAM
ld hl, wc608
ld de, $a001
ld de, s7_a001
ld bc, wc7bd - wc608
call CopyBytes
call CloseSRAM
@@ -2485,7 +2485,7 @@ Function10107d:
ld bc, NAME_LENGTH
call .CopyAllFromOT
ld hl, wOTPartyMon1Species
ld de, $c699
ld de, wc699
ld bc, PARTYMON_STRUCT_LENGTH
call .CopyAllFromOT
ld a, $50
@@ -3111,7 +3111,7 @@ Function1014a6:
Function1014b7:
call GetJoypad
ldh a, [hJoyPressed]
and $03
and A_BUTTON | B_BUTTON
jr nz, .asm_1014c5
ld hl, wcd42
dec [hl]
@@ -3831,7 +3831,7 @@ _StartMobileBattle:
.CopyOTDetails:
ldh a, [rSVBK]
push af
ld a, 5
ld a, BANK(w5_dc0d)
ldh [rSVBK], a
ld bc, w5_dc0d
@@ -4723,13 +4723,13 @@ Function1020ea:
ret
Function102112:
ld a, $04
ld a, BANK(s4_a03b)
call OpenSRAM
ld hl, $a041
ld hl, s4_a03b + 6
ld c, 40
.outer_loop
push hl
ld de, $c60f
ld de, wc60f
ld b, 31
.inner_loop
ld a, [de]