Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Some Mobile code labeling and removed magic numbers (#993)

Browse Source 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
This commit is contained in:
Andrew Cook
2022-09-15 10:49:58 +10:00
committed by GitHub
parent 41d5ea0482
commit 0f5540740b
19 changed files with 536 additions and 468 deletions
Download Patch File Download Diff File Expand all files Collapse all files

73
mobile/mobile_5f.asm
View File

@@ -265,27 +265,27 @@ CheckStringForErrors_IgnoreTerminator:
ret
Function17d0f3:
ld a, [wc608 + 5]
ld a, [wMobileMonSpecies]
ld [wOTTrademonSpecies], a
ld [wCurPartySpecies], a
ld a, [wcd81]
ld [wc74e], a
ld hl, wc608 + 53
ld hl, wMobileMonOT
ld de, wOTTrademonOTName
ld bc, 5
ld bc, NAME_LENGTH_JAPANESE - 1
call CopyBytes
ld a, "@"
ld [de], a
ld a, [wc608 + 11]
ld a, [wMobileMonID]
ld [wOTTrademonID], a
ld a, [wc608 + 12]
ld a, [wMobileMonID + 1]
ld [wOTTrademonID + 1], a
ld hl, wc608 + 26
ld hl, wMobileMonDVs
ld a, [hli]
ld [wOTTrademonDVs], a
ld a, [hl]
ld [wOTTrademonDVs + 1], a
ld bc, wc608 + 5
ld bc, wMobileMonSpecies
farcall GetCaughtGender
ld a, c
ld [wOTTrademonCaughtData], a
@@ -301,10 +301,10 @@ Function17d0f3:
xor a
ld [wLinkMode], a
farcall SaveAfterLinkTrade
ld a, $5
ld a, BANK(s5_a800)
call OpenSRAM
ld a, $5
ld [$a800], a
ld a, BANK(s5_a800)
ld [s5_a800], a
call CloseSRAM
ld a, [wMapGroup]
ld b, a
@@ -324,8 +324,8 @@ Function17d0f3:
Mobile_CopyDefaultOTName:
ld hl, Mobile5F_PlayersName
ld de, wc63d
ld bc, 5
ld de, wMobileMonOT
ld bc, NAME_LENGTH_JAPANESE - 1
call CopyBytes
ret
@@ -334,8 +334,8 @@ Mobile5F_PlayersName:
Mobile_CopyDefaultNickname:
ld hl, .DefaultNickname
ld de, wc642
ld bc, 5
ld de, wMobileMonNick
ld bc, NAME_LENGTH_JAPANESE - 1
call CopyBytes
ret
@@ -344,26 +344,27 @@ Mobile_CopyDefaultNickname:
Mobile_CopyDefaultMail:
ld a, "@"
ld hl, wc647
ld hl, wMobileMonMail
ld bc, MAIL_MSG_LENGTH + 1
call ByteFill
ld hl, .DefaultMessage
ld de, wc647
ld bc, 6
ld de, wMobileMonMail
ld bc, .DefaultMessageEnd - .DefaultMessage
call CopyBytes
ret
.DefaultMessage:
db "こんにちは@"
.DefaultMessageEnd:
Mobile_CopyDefaultMailAuthor:
ld a, "@"
ld de, wc668
ld bc, 5
ld de, wMobileMonMailAuthor
ld bc, NAME_LENGTH_JAPANESE - 1
call ByteFill
ld hl, Mobile5F_PlayersName
ld de, wc668
ld bc, 5
ld de, wMobileMonMailAuthor
ld bc, NAME_LENGTH_JAPANESE - 1
call CopyBytes
ret
@@ -542,20 +543,20 @@ Function17d2ce:
ret
Function17d314:
ld a, $5
ld a, BANK(s5_b1b1)
call OpenSRAM
ld a, [$b1b1]
ld a, [s5_b1b1]
call CloseSRAM
cp $21
jr nc, .asm_17d354
ld a, $6
ld a, BANK(s6_a006)
call OpenSRAM
ld l, $0
ld l, 0
ld h, l
ld de, $a006
ld a, [$a004]
ld de, s6_a006
ld a, [s6_a004]
ld c, a
ld a, [$a005]
ld a, [s6_a005]
ld b, a
.asm_17d336
push bc
@@ -569,10 +570,10 @@ Function17d314:
ld a, b
or c
jr nz, .asm_17d336
ld a, [$a002]
ld a, [s6_a002]
cp l
jr nz, .asm_17d354
ld a, [$a003]
ld a, [s6_a003]
cp h
jr nz, .asm_17d354
call CloseSRAM
@@ -635,10 +636,10 @@ Function17d370:
ld [wBGMapBuffer], a
ld a, $d0
ld [wcd21], a
ld a, $6
ld a, BANK(s6_a006)
call OpenSRAM
ld hl, $a006
ld de, wBGPals1
ld hl, s6_a006
ld de, w4_d000
ld bc, $1000
call CopyBytes
call CloseSRAM
@@ -1176,11 +1177,11 @@ Function17d78d:
ld a, [hli]
ld b, a
call HlToCrashCheckPointer
ld a, $6
ld a, BANK(s6_a006)
call OpenSRAM
ld hl, $a006
ld hl, s6_a006
add hl, bc
ld de, wBGPals1
ld de, w4_d000
ld bc, $1000
call CopyBytes
call CloseSRAM