Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename dt and dd to bigdt and bigdd (#1141)

Browse Source 
This makes their big-endianness obvious and matches `bigdw`
This commit is contained in:
Sylvie
2024-10-17 14:52:47 -04:00
committed by GitHub
parent 901813a343
commit 2265e53d24
10 changed files with 273 additions and 269 deletions
Download Patch File Download Diff File Expand all files Collapse all files

420
data/battle_tower/parties.asm
View File

File diff suppressed because it is too large Load Diff

28
data/events/odd_eggs.asm
View File

@@ -40,7 +40,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db THUNDERSHOCK, CHARM, DIZZY_PUNCH, 0 db THUNDERSHOCK, CHARM, DIZZY_PUNCH, 0
dw 02048 ; OT ID dw 02048 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -66,7 +66,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db THUNDERSHOCK, CHARM, DIZZY_PUNCH, 0 db THUNDERSHOCK, CHARM, DIZZY_PUNCH, 0
dw 00256 ; OT ID dw 00256 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -92,7 +92,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db POUND, CHARM, DIZZY_PUNCH, 0 db POUND, CHARM, DIZZY_PUNCH, 0
dw 04096 ; OT ID dw 04096 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -118,7 +118,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db POUND, CHARM, DIZZY_PUNCH, 0 db POUND, CHARM, DIZZY_PUNCH, 0
dw 00768 ; OT ID dw 00768 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -144,7 +144,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db SING, CHARM, DIZZY_PUNCH, 0 db SING, CHARM, DIZZY_PUNCH, 0
dw 04096 ; OT ID dw 04096 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -170,7 +170,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db SING, CHARM, DIZZY_PUNCH, 0 db SING, CHARM, DIZZY_PUNCH, 0
dw 00768 ; OT ID dw 00768 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -196,7 +196,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db POUND, LICK, DIZZY_PUNCH, 0 db POUND, LICK, DIZZY_PUNCH, 0
dw 03584 ; OT ID dw 03584 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -222,7 +222,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db POUND, LICK, DIZZY_PUNCH, 0 db POUND, LICK, DIZZY_PUNCH, 0
dw 00512 ; OT ID dw 00512 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -248,7 +248,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db EMBER, DIZZY_PUNCH, 0, 0 db EMBER, DIZZY_PUNCH, 0, 0
dw 02560 ; OT ID dw 02560 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -274,7 +274,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db EMBER, DIZZY_PUNCH, 0, 0 db EMBER, DIZZY_PUNCH, 0, 0
dw 00512 ; OT ID dw 00512 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -300,7 +300,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db QUICK_ATTACK, LEER, DIZZY_PUNCH, 0 db QUICK_ATTACK, LEER, DIZZY_PUNCH, 0
dw 03072 ; OT ID dw 03072 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -326,7 +326,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db QUICK_ATTACK, LEER, DIZZY_PUNCH, 0 db QUICK_ATTACK, LEER, DIZZY_PUNCH, 0
dw 00512 ; OT ID dw 00512 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -352,7 +352,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db TACKLE, DIZZY_PUNCH, 0, 0 db TACKLE, DIZZY_PUNCH, 0, 0
dw 02560 ; OT ID dw 02560 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0
@@ -378,7 +378,7 @@ OddEggs:
db NO_ITEM db NO_ITEM
db TACKLE, DIZZY_PUNCH, 0, 0 db TACKLE, DIZZY_PUNCH, 0, 0
dw 00256 ; OT ID dw 00256 ; OT ID
dt 125 ; Exp bigdt 125 ; Exp
; Stat exp ; Stat exp
bigdw 0 bigdw 0
bigdw 0 bigdw 0

5
data/items/mom_phone.asm
View File

@@ -1,7 +1,6 @@
MACRO momitem MACRO momitem
; money to trigger, cost, kind, item ; money to trigger, cost, kind, item
dt \1 bigdt \1, \2
dt \2
db \3, \4 db \3, \4
ENDM ENDM
@@ -26,4 +25,4 @@ MomItems_2:
momitem 100000, 22800, MOM_DOLL, DECO_BIG_SNORLAX_DOLL momitem 100000, 22800, MOM_DOLL, DECO_BIG_SNORLAX_DOLL
.End .End
dt 0 ; unused bigdt 0 ; unused

29
engine/events/mom.asm
View File

@@ -552,26 +552,15 @@ Mom_WithdrawDepositMenuJoypad:
ret ret
.DigitQuantities: .DigitQuantities:
dt 100000 for x, 5, -1, -1
dt 10000 bigdt 10**x
dt 1000 endr
dt 100 for x, 5, -1, -1
dt 10 bigdt 10**x
dt 1 endr
for x, 5, -1, -1
dt 100000 bigdt 9 * 10**x
dt 10000 endr
dt 1000
dt 100
dt 10
dt 1
dt 900000
dt 90000
dt 9000
dt 900
dt 90
dt 9
MomLeavingText1: MomLeavingText1:
text_far _MomLeavingText1 text_far _MomLeavingText1

1
engine/events/mom_phone.asm
View File

@@ -228,7 +228,6 @@ MomItsInYourRoomText:
text_far _MomItsInYourRoomText text_far _MomItsInYourRoomText
text_end text_end
DummyPredef3A_DummyData: ; unreferenced DummyPredef3A_DummyData: ; unreferenced
db 0 db 0

2
engine/events/money.asm
View File

@@ -23,7 +23,7 @@ GiveMoney::
ret ret
MaxMoney: MaxMoney:
dt MAX_MONEY bigdt MAX_MONEY
TakeMoney:: TakeMoney::
ld a, 3 ld a, 3

25
macros/data.asm
View File

@@ -55,16 +55,25 @@ MACRO dc ; "crumbs"
endr endr
ENDM ENDM
MACRO dt ; three-byte (big-endian)
db LOW((\1) >> 16), HIGH(\1), LOW(\1)
ENDM
MACRO dd ; four-byte (big-endian)
db HIGH((\1) >> 16), LOW((\1) >> 16), HIGH(\1), LOW(\1)
ENDM
MACRO bigdw ; big-endian word MACRO bigdw ; big-endian word
rept _NARG
db HIGH(\1), LOW(\1) db HIGH(\1), LOW(\1)
shift
endr
ENDM
MACRO bigdt ; big-endian "tribyte"
rept _NARG
db LOW((\1) >> 16), HIGH(\1), LOW(\1)
shift
endr
ENDM
MACRO bigdd ; big-endian "double word"
rept _NARG
db HIGH((\1) >> 16), LOW((\1) >> 16), HIGH(\1), LOW(\1)
shift
endr
ENDM ENDM
MACRO dba ; dbw bank, address MACRO dba ; dbw bank, address

8
macros/legacy.asm
View File

@@ -13,6 +13,14 @@ ENDM
; macros/data.asm ; macros/data.asm
MACRO dt
bigdt \1
ENDM
MACRO dd
bigdd \1
ENDM
MACRO dbbw MACRO dbbw
db \1, \2 db \1, \2
dw \3 dw \3

6
macros/scripts/events.asm
View File

@@ -229,21 +229,21 @@ ENDM
MACRO givemoney MACRO givemoney
db givemoney_command db givemoney_command
db \1 ; account db \1 ; account
dt \2 ; money bigdt \2 ; money
ENDM ENDM
const takemoney_command ; $23 const takemoney_command ; $23
MACRO takemoney MACRO takemoney
db takemoney_command db takemoney_command
db \1 ; account db \1 ; account
dt \2 ; money bigdt \2 ; money
ENDM ENDM
const checkmoney_command ; $24 const checkmoney_command ; $24
MACRO checkmoney MACRO checkmoney
db checkmoney_command db checkmoney_command
db \1 ; account db \1 ; account
dt \2 ; money bigdt \2 ; money
ENDM ENDM
const givecoins_command ; $25 const givecoins_command ; $25

16
mobile/mobile_41.asm
View File

@@ -698,21 +698,21 @@ endr
ret ret
._9 ._9
dd 1000000000 bigdd 10**9
._8 ._8
dd 100000000 bigdd 10**8
._7 ._7
dd 10000000 bigdd 10**7
._6 ._6
dd 1000000 bigdd 10**6
._5 ._5
dd 100000 bigdd 10**5
._4 ._4
dd 10000 bigdd 10**4
._3 ._3
dd 1000 bigdd 10**3
._2 ._2
dd 100 bigdd 10**2
.Function1062b2: .Function1062b2:
ld c, $0 ld c, $0