Avoid using EQUS when EQU or MACRO will do (#1166)

This commit is contained in:
Rangi
2025-02-27 13:07:12 -05:00
committed by GitHub
parent 7a7a06289c
commit 4d6c3e2975
8 changed files with 91 additions and 34 deletions

View File

@@ -1,6 +1,12 @@
DEF NUM_MOM_ITEMS_1 EQUS "((MomItems_1.End - MomItems_1) / 8)"
DEF NUM_MOM_ITEMS_2 EQUS "((MomItems_2.End - MomItems_2) / 8)"
; Constants for momitem offsets (see data/items/mom_phone.asm)
rsreset
DEF MOMITEM_TRIGGER rb 3 ; 0
DEF MOMITEM_COST rb 3 ; 3
DEF MOMITEM_KIND rb ; 6
DEF MOMITEM_ITEM rb ; 7
DEF MOMITEM_SIZE EQU _RS ; 8
; momitem kind values
const_def 1
const MOM_ITEM
const MOM_DOLL
@@ -57,9 +63,10 @@ MomTriesToBuySomething::
CheckBalance_MomItem2:
ld a, [wWhichMomItem]
cp NUM_MOM_ITEMS_2
cp (MomItems_2.End - MomItems_2) / MOMITEM_SIZE
jr nc, .nope
call GetItemFromMom
assert MOMITEM_TRIGGER == 0
ld a, [hli]
ldh [hMoneyTemp], a
ld a, [hli]
@@ -100,7 +107,7 @@ CheckBalance_MomItem2:
.exact
call .AddMoney
ld a, NUM_MOM_ITEMS_1
ld a, (MomItems_1.End - MomItems_1) / MOMITEM_SIZE
call RandomRange
inc a
ld [wWhichMomItemSet], a
@@ -115,7 +122,7 @@ CheckBalance_MomItem2:
MomBuysItem_DeductFunds:
call GetItemFromMom
ld de, 3 ; cost
ld de, MOMITEM_COST
add hl, de
ld a, [hli]
ldh [hMoneyTemp], a
@@ -130,11 +137,12 @@ MomBuysItem_DeductFunds:
Mom_GiveItemOrDoll:
call GetItemFromMom
ld de, 6 ; item type
ld de, MOMITEM_KIND
add hl, de
ld a, [hli]
cp MOM_ITEM
jr z, .not_doll
assert MOMITEM_KIND + 1 == MOMITEM_ITEM
ld a, [hl]
ld c, a
ld b, 1
@@ -153,7 +161,7 @@ Mom_GiveItemOrDoll:
Mom_GetScriptPointer:
call GetItemFromMom
ld de, 6 ; item type
ld de, MOMITEM_KIND
add hl, de
ld a, [hli]
ld de, .ItemScript
@@ -186,7 +194,7 @@ GetItemFromMom:
.zero
ld a, [wWhichMomItem]
cp NUM_MOM_ITEMS_2
cp (MomItems_2.End - MomItems_2) / MOMITEM_SIZE
jr c, .ok
xor a
@@ -196,7 +204,8 @@ GetItemFromMom:
.GetFromList1:
ld l, a
ld h, 0
rept 3 ; multiply hl by 8
assert MOMITEM_SIZE == 8
rept 3 ; multiply hl by MOMITEM_SIZE
add hl, hl
endr
add hl, de

View File

@@ -1,9 +1,6 @@
DEF CARDFLIP_LIGHT_OFF EQU "♂" ; $ef
DEF CARDFLIP_LIGHT_ON EQU "♀" ; $f5
DEF CARDFLIP_DECK_SIZE EQUS "(wDeckEnd - wDeck)"
assert wDiscardPileEnd - wDiscardPile == wDeckEnd - wDeck
MemoryGameGFX:
; Graphics for an unused Game Corner
; game were meant to be here.