Document constants with comments, actual names, and more thorough usage

2017-12-09 00:50:59 -05:00
parent 89b9292db0
commit 512863989f
86 changed files with 2222 additions and 1980 deletions
--- a/main.asm
+++ b/main.asm
@@ -1481,7 +1481,7 @@ PlayBattleMusic: ; 2ee6c
 	jr nz, .othertrainer

 	ld a, [OtherTrainerID]
-	cp 4 ; Rival in Indigo Plateau
+	cp RIVAL2_2_CHIKORITA ; Rival in Indigo Plateau
 	jr c, .done
 	ld de, MUSIC_CHAMPION_BATTLE
 	jr .done