Document a bugfix: 1/256 failure rate for 100% effect chance

2019-01-05 20:29:45 -05:00
parent 3650232398
commit 5207615cdc
2 changed files with 32 additions and 0 deletions
--- a/engine/battle/effect_commands.asm
+++ b/engine/battle/effect_commands.asm
@@ -1877,6 +1877,8 @@ BattleCommand_EffectChance:
 	ld hl, wEnemyMoveStruct + MOVE_CHANCE
 .got_move_chance

+	; BUG: 1/256 chance to fail even for a 100% effect chance,
+	; since carry is not set if BattleRandom == [hl] == 255
 	call BattleRandom
 	cp [hl]
 	pop hl