From 60cd04b02300c288a01a2f78a44cb39cbe6861d1 Mon Sep 17 00:00:00 2001 From: PikalaxALT Date: Sat, 18 Jul 2015 23:45:39 -0400 Subject: [PATCH] Trainer data structure and field move functions Trainer data in map scripts is now a macro-defined structure. Field move functions in main.asm are now nearly completely annotated, with local references. Trailing white space deleted. --- battle/ai/scoring.asm | 12 +- constants/battle_constants.asm | 380 ++-- constants/event_flags.asm | 35 +- constants/item_constants.asm | 10 + constants/phone_constants.asm | 69 +- constants/sfx_constants.asm | 412 ++-- engine/events_2.asm | 2 +- engine/map_objects.asm | 12 +- engine/movement.asm | 12 +- engine/pack.asm | 4 +- engine/scripting.asm | 10 +- engine/spawn_points.asm | 2 +- engine/specials.asm | 12 +- engine/std_scripts.asm | 4 +- gbhw.asm | 2 +- home.asm | 32 +- home/map.asm | 6 +- home/menu.asm | 16 +- home/vblank.asm | 2 +- items/item_attributes.asm | 1798 +++--------------- items/item_effects.asm | 8 +- macros/movement.asm | 18 +- macros/trainer.asm | 7 + main.asm | 1786 ++++++++--------- maps/AzaleaGym.asm | 90 +- maps/BlackthornGym1F.asm | 54 +- maps/BlackthornGym2F.asm | 36 +- maps/CeladonGym.asm | 90 +- maps/CeruleanGym.asm | 54 +- maps/CianwoodGym.asm | 72 +- maps/DanceTheatre.asm | 90 +- maps/DragonsDenB1F.asm | 72 +- maps/EcruteakGym.asm | 72 +- maps/ElmsLab.asm | 2 +- maps/FastShipB1F.asm | 180 +- maps/FastShipCabins_NNW_NNE_NE.asm | 108 +- maps/FastShipCabins_SE_SSE_CaptainsCabin.asm | 126 +- maps/FastShipCabins_SW_SSW_NW.asm | 72 +- maps/GoldenrodBillsHouse.asm | 6 +- maps/GoldenrodGym.asm | 72 +- maps/IlexForest.asm | 18 +- maps/KrissHouse2F.asm | 2 +- maps/LakeofRage.asm | 72 +- maps/MahoganyGym.asm | 90 +- maps/MountMortar1FInside.asm | 36 +- maps/MountMortar2FInside.asm | 18 +- maps/NationalPark.asm | 84 +- maps/OlivineLighthouse2F.asm | 42 +- maps/OlivineLighthouse3F.asm | 54 +- maps/OlivineLighthouse4F.asm | 36 +- maps/OlivineLighthouse5F.asm | 36 +- maps/PewterGym.asm | 18 +- maps/RadioTower1F.asm | 18 +- maps/RadioTower2F.asm | 88 +- maps/RadioTower3F.asm | 72 +- maps/RadioTower4F.asm | 72 +- maps/RadioTower5F.asm | 18 +- maps/Route1.asm | 36 +- maps/Route10South.asm | 36 +- maps/Route11.asm | 72 +- maps/Route12.asm | 72 +- maps/Route13.asm | 90 +- maps/Route14.asm | 54 +- maps/Route15.asm | 108 +- maps/Route17.asm | 72 +- maps/Route18.asm | 36 +- maps/Route19.asm | 72 +- maps/Route2.asm | 54 +- maps/Route20.asm | 54 +- maps/Route21.asm | 54 +- maps/Route25.asm | 126 +- maps/Route26.asm | 120 +- maps/Route27.asm | 120 +- maps/Route3.asm | 72 +- maps/Route30.asm | 60 +- maps/Route31.asm | 24 +- maps/Route32.asm | 156 +- maps/Route33.asm | 24 +- maps/Route34.asm | 156 +- maps/Route35.asm | 156 +- maps/Route36.asm | 42 +- maps/Route37.asm | 54 +- maps/Route38.asm | 120 +- maps/Route39.asm | 78 +- maps/Route4.asm | 54 +- maps/Route40.asm | 72 +- maps/Route41.asm | 180 +- maps/Route42.asm | 60 +- maps/Route43.asm | 120 +- maps/Route44.asm | 138 +- maps/Route45.asm | 138 +- maps/Route46.asm | 60 +- maps/Route6.asm | 36 +- maps/Route8.asm | 90 +- maps/Route9.asm | 108 +- maps/RuinsofAlphOmanyteChamber.asm | 2 +- maps/RuinsofAlphOutside.asm | 36 +- maps/SaffronGym.asm | 72 +- maps/SlowpokeWellB1F.asm | 72 +- maps/SproutTower1F.asm | 18 +- maps/SproutTower2F.asm | 36 +- maps/SproutTower3F.asm | 54 +- maps/TeamRocketBaseB1F.asm | 36 +- maps/TeamRocketBaseB2F.asm | 54 +- maps/TeamRocketBaseB3F.asm | 72 +- maps/UndergroundPathSwitchRoomEntrances.asm | 108 +- maps/UndergroundWarehouse.asm | 54 +- maps/UnionCave1F.asm | 90 +- maps/UnionCaveB1F.asm | 72 +- maps/UnionCaveB2F.asm | 54 +- maps/VermilionGym.asm | 54 +- maps/VioletGym.asm | 36 +- maps/WarehouseEntrance.asm | 72 +- maps/WiseTriosRoom.asm | 54 +- misc/mobile_40.asm | 6 +- wram.asm | 6 +- 116 files changed, 2148 insertions(+), 8705 deletions(-) diff --git a/battle/ai/scoring.asm b/battle/ai/scoring.asm index 425d6911b..d382011a6 100644 --- a/battle/ai/scoring.asm +++ b/battle/ai/scoring.asm @@ -151,7 +151,7 @@ AI_Setup: ; 385e0 AI_Types: ; 38635 ; Dismiss any move that the player is immune to. ; Encourage super-effective moves. -; Discourage not very effective moves unless +; Discourage not very effective moves unless ; all damaging moves are of the same type. ld hl, Buffer1 - 1 @@ -963,9 +963,9 @@ AI_Smart_Bide: ; 38a1e AI_Smart_Whirlwind: ; 38a2a ; Whirlwind, Roar. -; Discourage this move if the player has not shown +; Discourage this move if the player has not shown ; a super-effective move against the enemy. -; Consider player's type(s) if its moves are unknown. +; Consider player's type(s) if its moves are unknown. push hl callab Function3484e @@ -1231,7 +1231,7 @@ AI_Smart_Paralyze: ; 38b26 call AICheckPlayerQuarterHP jr nc, .asm_38b3a -; 80% chance to greatly encourage this move +; 80% chance to greatly encourage this move ; if enemy is slower than player and its HP is above 25%. call AICompareSpeed ret c @@ -1879,7 +1879,7 @@ AI_Smart_MeanLook: ; 38dfb bit SUBSTATUS_TOXIC, a jr nz, .asm_38e26 -; 80% chance to greatly encourage this move if the player is either +; 80% chance to greatly encourage this move if the player is either ; in love, identified, stuck in Rollout, or has a Nightmare. ld a, [PlayerSubStatus1] and 1<