Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix bug doc formatting

Browse Source
This commit is contained in:
Rangi42
2024-01-01 21:46:23 -05:00
parent 184c53e8ca
commit 804fa846e0
2 changed files with 5 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/bugs_and_glitches.md
View File

@@ -83,7 +83,7 @@ Fixes in the [multi-player battle engine](#multi-player-battle-engine) category
- [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists) - [Team Rocket battle music is not used for Executives or Scientists](#team-rocket-battle-music-is-not-used-for-executives-or-scientists)
- [No bump noise if standing on tile `$3E`](#no-bump-noise-if-standing-on-tile-3e) - [No bump noise if standing on tile `$3E`](#no-bump-noise-if-standing-on-tile-3e)
- [Playing Entei's Pokédex cry can distort Raikou's and Suicune's](#playing-enteis-pok%C3%A9dex-cry-can-distort-raikous-and-suicunes) - [Playing Entei's Pokédex cry can distort Raikou's and Suicune's](#playing-enteis-pok%C3%A9dex-cry-can-distort-raikous-and-suicunes)
- [`SFX_RUN` does not play correctly when a wild Pokemon flees from battle](#sfx_run-does-not-play-correctly-when-a-wild-pokemon-flees-from-battle) - [`SFX_RUN` does not play correctly when a wild Pokémon flees from battle](#sfx_run-does-not-play-correctly-when-a-wild-pok%C3%A9mon-flees-from-battle)
- [Text](#text) - [Text](#text)
- [Five-digit experience gain is printed incorrectly](#five-digit-experience-gain-is-printed-incorrectly) - [Five-digit experience gain is printed incorrectly](#five-digit-experience-gain-is-printed-incorrectly)
- [Only the first three evolution entries can have Stone compatibility reported correctly](#only-the-first-three-evolution-entries-can-have-stone-compatibility-reported-correctly) - [Only the first three evolution entries can have Stone compatibility reported correctly](#only-the-first-three-evolution-entries-can-have-stone-compatibility-reported-correctly)
@@ -2729,23 +2729,13 @@ This bug allows all the options to be updated at once if the left or right butto
``` ```
### `SFX_RUN` does not play correctly when a wild Pokemon flees from battle ### `SFX_RUN` does not play correctly when a wild Pokémon flees from battle
Due to the wrong function being called, `SFX_RUN` is never heard when a wild Pokemon flees from battle. **Fix:** Edit `WildFled_EnemyFled_LinkBattleCanceled` in [engine/battle/core.asm](https://github.com/pret/pokecrystal/blob/master/engine/battle/core.asm):
**Fix:** Edit `WildFled_EnemyFled_LinkBattleCanceled` in [engine/battle/core.asm]
(https://github.com/pret/pokecrystal/blob/master/engine/battle/core.asm):
```diff ```diff
.skip_text
-; BUG: SFX_RUN does not play correctly when a wild Pokemon flees from battle (see docs/bugs_and_glitches.md) -; BUG: SFX_RUN does not play correctly when a wild Pokemon flees from battle (see docs/bugs_and_glitches.md)
call StopDangerSound
call CheckMobileBattleError
jr c, .skip_sfx
ld de, SFX_RUN ld de, SFX_RUN
- call PlaySFX - call PlaySFX
+ call WaitPlaySFX + call WaitPlaySFX
.skip_sfx
``` ```

2
engine/battle/core.asm
View File

@@ -143,11 +143,11 @@ WildFled_EnemyFled_LinkBattleCanceled:
call StdBattleTextbox call StdBattleTextbox
.skip_text .skip_text
; BUG: SFX_RUN does not play correctly when a wild Pokemon flees from battle (see docs/bugs_and_glitches.md)
call StopDangerSound call StopDangerSound
call CheckMobileBattleError call CheckMobileBattleError
jr c, .skip_sfx jr c, .skip_sfx
; BUG: SFX_RUN does not play correctly when a wild Pokémon flees from battle (see docs/bugs_and_glitches.md)
ld de, SFX_RUN ld de, SFX_RUN
call PlaySFX call PlaySFX