Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up the recently documented bug fixes

Browse Source
This commit is contained in:
Rangi
2021-09-05 12:40:32 -04:00
parent 35f6b6e68c
commit 8059d0c845
4 changed files with 59 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
docs/design_flaws.md
View File

@@ -13,8 +13,6 @@ These are parts of the code that do not work *incorrectly*, like [bugs and glitc
- [Pokédex entry banks are derived from their species IDs](#pokédex-entry-banks-are-derived-from-their-species-ids)
- [Identical sine wave code and data is repeated five times](#identical-sine-wave-code-and-data-is-repeated-five-times)
- [`GetForestTreeFrame` works, but it's still bad](#getforesttreeframe-works-but-its-still-bad)
- [Second rival battle's DVs are lower than the first](#second-rival-battles-dvs-are-lower-than-the-first)
- [The Ruins of Alph research center's roof color at night looks wrong](#the-ruins-of-alph-research-centers-roof-color-at-night-looks-wrong)
## Pic banks are offset by `PICS_FIX`
@@ -590,7 +588,7 @@ Edit [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/ma
ld a, BANK(PokedexDataPointerTable)
call GetFarWord
+ pop de
.SkipText:
- call GetPokedexEntryBank
+ ld a, d
@@ -598,7 +596,7 @@ Edit [engine/items/item_effects.asm](https://github.com/pret/pokecrystal/blob/ma
inc hl
cp "@"
jr nz, .SkipText
- call GetPokedexEntryBank
+ ld a, d
push bc
@@ -793,34 +791,3 @@ Edit `GetForestTreeFrame`:
+ add a
ret
```
## Second rival battle's DVs are lower than the first
The second rival battle has Pokémon whose DVs are actually *lower* than the DVs of the Pokémon from the first rival battle, which doesn't align with Silver's beliefs throughout the game.
**Fix:**
Edit [data/trainers/dvs.asm](https://github.com/pret/pokecrystal/blob/master/data/trainers/dvs.asm) to adjust the DVs of RIVAL2 to those of RIVAL1:
```diff
dn 13, 13, 13, 13 ; RIVAL1
...
- dn 9, 8, 8, 8 ; RIVAL2
+ dn 13, 13, 13, 13 ; RIVAL2
```
## The Ruins of Alph research center's roof color at night looks wrong
The Ruins of Alph research center's roof looks wonky during the night, making it look unprofessional.
**Fix:**
Edit [gfx/tilesets/roofs.pal](https://github.com/pret/pokecrystal/blob/master/gfx/tilesets/roofs.pal) to adjust Group 3's night palette to a suitable one (that of Pewter City's roofs in this instance):
```diff
; group 3 (dungeons)
RGB 21,21,21, 11,11,11 ; morn/day
- RGB 21,21,21, 17,08,07 ; nite
+ RGB 09,09,11, 04,05,07 ; nite
```