From 8755a88458b912975c537e489e182ca956dcac9b Mon Sep 17 00:00:00 2001 From: i0brendan0 <19826742+i0brendan0@users.noreply.github.com> Date: Sat, 21 Jul 2018 05:05:40 -0500 Subject: [PATCH] turns out none of the code is needed --- docs/bugs_and_glitches.md | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index 4aeb088ef..7dfd8f421 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -302,18 +302,11 @@ Fix: ```asm CheckHiddenOpponent: ; 37daa - ld a, BATTLE_VARS_SUBSTATUS5_OPP - call GetBattleVar - ld a, [hl] - and 1 << SUBSTATUS_LOCK_ON - cp 1 << SUBSTATUS_LOCK_ON - ret z - ld a, BATTLE_VARS_SUBSTATUS3_OPP - call GetBattleVar - and 1 << SUBSTATUS_FLYING | 1 << SUBSTATUS_UNDERGROUND ret ``` +The code in `CheckHiddenOpponent` is completely redundant as `CheckHit` already does what this code is doing. Another option is to remove `CheckHiddenOpponent` completely, the calls to `CheckHiddenOpponent`, and the jump afterwards. + ## Beat Up can desynchronize link battles *Fixing this bug will break compatibility with standard Pokémon Crystal for link battles.*