From 8befc889adcaf3988ad63a36de74fa345aeab7ee Mon Sep 17 00:00:00 2001 From: mid-kid Date: Tue, 4 Aug 2020 20:26:26 +0200 Subject: [PATCH] Remove a verifiably false comment wSpriteAnimCount starts at 0, keeps incrementing and never decrements. When it reaches $ff, the next value is 1. Its purpose is unknown, as this value is used nowhere else. --- engine/gfx/sprites.asm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/engine/gfx/sprites.asm b/engine/gfx/sprites.asm index c5a91a9b5..fd87f398b 100644 --- a/engine/gfx/sprites.asm +++ b/engine/gfx/sprites.asm @@ -135,16 +135,16 @@ _InitSpriteAnimStruct:: ; Back up the structure address to bc. ld c, l ld b, h -; Value [wSpriteAnimCount] is initially set to -1. Set it to -; the number of objects loaded into this array. + +; Increment [wSpriteAnimCount], skipping a 0 value. ld hl, wSpriteAnimCount inc [hl] ld a, [hl] and a - jr nz, .initialized + jr nz, .nonzero inc [hl] +.nonzero -.initialized ; Get row a of SpriteAnimSeqData, copy the pointer into de pop af ld e, a @@ -228,9 +228,9 @@ DeinitializeAllSprites: UpdateAnimFrame: call InitSpriteAnimBuffer ; init WRAM call GetSpriteAnimFrame ; read from a memory array - cp -3 + cp dowait_command jr z, .done - cp -4 + cp delanim_command jr z, .delete call GetFrameOAMPointer ; add byte to [wCurAnimVTile]