Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rename some labels

Browse Source 
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"

Fixes #789
This commit is contained in:
Rangi
2020-12-23 16:29:30 -05:00
parent 1a054661ec
commit 99e66c2557
106 changed files with 584 additions and 578 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
engine/events/pokecenter_pc.asm
View File

@@ -342,13 +342,13 @@ PlayerWithdrawItemMenu:
.Submenu:
; check if the item has a quantity
farcall _CheckTossableItem
ld a, [wItemAttributeParamBuffer]
ld a, [wItemAttributeValue]
and a
jr z, .askquantity
; items without quantity are always ×1
ld a, 1
ld [wItemQuantityChangeBuffer], a
ld [wItemQuantityChange], a
jr .withdraw
.askquantity
@@ -360,15 +360,15 @@ PlayerWithdrawItemMenu:
jr c, .done
.withdraw
ld a, [wItemQuantityChangeBuffer]
ld [wPCItemQuantityChangeBuffer], a
ld a, [wItemQuantityChange]
ld [wPCItemQuantityChange], a
ld a, [wCurItemQuantity]
ld [wPCItemQuantity], a
ld hl, wNumItems
call ReceiveItem
jr nc, .PackFull
ld a, [wPCItemQuantityChangeBuffer]
ld [wItemQuantityChangeBuffer], a
ld a, [wPCItemQuantityChange]
ld [wItemQuantityChange], a
ld a, [wPCItemQuantity]
ld [wCurItemQuantity], a
ld hl, wNumPCItems
@@ -469,7 +469,7 @@ PlayerDepositItemMenu:
ld a, FALSE
ld [wSpriteUpdatesEnabled], a
farcall CheckItemMenu
ld a, [wItemAttributeParamBuffer]
ld a, [wItemAttributeValue]
ld hl, .dw
rst JumpTable
pop af
@@ -490,7 +490,7 @@ PlayerDepositItemMenu:
ret
.tossable
ld a, [wPCItemQuantityChangeBuffer]
ld a, [wPCItemQuantityChange]
push af
ld a, [wPCItemQuantity]
push af
@@ -498,16 +498,16 @@ PlayerDepositItemMenu:
pop af
ld [wPCItemQuantity], a
pop af
ld [wPCItemQuantityChangeBuffer], a
ld [wPCItemQuantityChange], a
ret
.DepositItem:
farcall _CheckTossableItem
ld a, [wItemAttributeParamBuffer]
ld a, [wItemAttributeValue]
and a
jr z, .AskQuantity
ld a, 1
ld [wItemQuantityChangeBuffer], a
ld [wItemQuantityChange], a
jr .ContinueDeposit
.AskQuantity:
@@ -521,15 +521,15 @@ PlayerDepositItemMenu:
jr c, .DeclinedToDeposit
.ContinueDeposit:
ld a, [wItemQuantityChangeBuffer]
ld [wPCItemQuantityChangeBuffer], a
ld a, [wItemQuantityChange]
ld [wPCItemQuantityChange], a
ld a, [wCurItemQuantity]
ld [wPCItemQuantity], a
ld hl, wNumPCItems
call ReceiveItem
jr nc, .NoRoomInPC
ld a, [wPCItemQuantityChangeBuffer]
ld [wItemQuantityChangeBuffer], a
ld a, [wPCItemQuantityChange]
ld [wItemQuantityChange], a
ld a, [wPCItemQuantity]
ld [wCurItemQuantity], a
ld hl, wNumItems
@@ -580,7 +580,7 @@ PCItemsJoypad:
ld c, 18
call Textbox
ld a, [wPCItemsCursor]
ld [wMenuCursorBuffer], a
ld [wMenuCursorPosition], a
ld a, [wPCItemsScrollPosition]
ld [wMenuScrollPosition], a
call ScrollingMenu