Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Explain a major AI-related bug with type matchup checks

Browse Source
This commit is contained in:
Fredrik Ljungdahl
2017-01-08 01:33:38 +01:00
parent f8455e9b4f
commit 9b8f57a730
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
battle/effect_commands.asm
View File

@@ -1542,6 +1542,12 @@ BattleCheckTypeMatchup: ; 347c8
jr z, CheckTypeMatchup jr z, CheckTypeMatchup
ld hl, BattleMonType1 ld hl, BattleMonType1
CheckTypeMatchup: ; 347d3 CheckTypeMatchup: ; 347d3
; There is an incorrect assumption about this function made in the AI related code: when
; the AI calls CheckTypeMatchup (not BattleCheckTypeMatchup), it assumes that placing the
; offensive type in a will make this function do the right thing. Since a is overwritten,
; this assumption is incorrect. A simple fix would be to load the move type for the
; current move into a in BattleCheckTypeMatchup, before falling through, which is
; consistent with how the rest of the code assumes this code works like.
push hl push hl
push de push de
push bc push bc