Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve some innacurate function names, labels, and comments (#1078)

Browse Source 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
This commit is contained in:
xCrystal
2024-01-07 12:38:00 +01:00
parent dbf6044650
commit bd6ceec193
107 changed files with 340 additions and 337 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
engine/menus/init_gender.asm
View File

@@ -25,7 +25,7 @@ InitGender:
call LoadGenderScreenPal
call LoadGenderScreenLightBlueTile
call WaitBGMap2
call SetPalettes
call SetDefaultBGPAndOBP
ld hl, AreYouABoyOrAreYouAGirlText
call PrintText
ld hl, .MenuHeader

2
engine/menus/main_menu.asm
View File

@@ -30,7 +30,7 @@ MainMenu:
call ClearTilemapEtc
ld b, SCGB_DIPLOMA
call GetSGBLayout
call SetPalettes
call SetDefaultBGPAndOBP
ld hl, wGameTimerPaused
res GAME_TIMER_PAUSED_F, [hl]
call MainMenu_GetWhichMenu

2
engine/menus/menu.asm
View File

@@ -703,7 +703,7 @@ RestoreOverworldMapTiles: ; unreferenced
ld bc, SCREEN_WIDTH * SCREEN_HEIGHT
call CopyBytes
call CloseSRAM
call OverworldTextModeSwitch
call LoadOverworldTilemapAndAttrmapPals
xor a ; sScratch
call OpenSRAM
ld hl, sScratch

2
engine/menus/naming_screen.asm
View File

@@ -55,7 +55,7 @@ NamingScreen:
call .GetNamingScreenSetup
call WaitBGMap
call WaitTop
call SetPalettes
call SetDefaultBGPAndOBP
call NamingScreen_InitNameEntry
ret

2
engine/menus/options_menu.asm
View File

@@ -48,7 +48,7 @@ _Option:
call WaitBGMap
ld b, SCGB_DIPLOMA
call GetSGBLayout
call SetPalettes
call SetDefaultBGPAndOBP
.joypad_loop
call JoyTextDelay

4
engine/menus/start_menu.asm
View File

@@ -33,7 +33,7 @@ StartMenu::
call DrawVariableLengthMenuBox
call .DrawBugContestStatusBox
call SafeUpdateSprites
call _OpenAndCloseMenu_HDMATransferTilemapAndAttrmap
call HDMATransferTilemapAndAttrmap_Menu
farcall LoadFonts_NoOAMUpdate
call .DrawBugContestStatus
call UpdateTimePals
@@ -514,7 +514,7 @@ StartMenu_Pokemon:
farcall WritePartyMenuTilemap
farcall PrintPartyMenuText
call WaitBGMap
call SetPalettes ; load regular palettes?
call SetDefaultBGPAndOBP
call DelayFrame
farcall PartyMenuSelect
jr c, .return ; if cancelled or pressed B

2
engine/menus/trainer_card.asm
View File

@@ -68,7 +68,7 @@ TrainerCard:
call WaitBGMap
ld b, SCGB_TRAINER_CARD
call GetSGBLayout
call SetPalettes
call SetDefaultBGPAndOBP
call WaitBGMap
ld hl, wJumptableIndex
xor a ; TRAINERCARDSTATE_PAGE1_LOADGFX