Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve some innacurate function names, labels, and comments (#1078)

Browse Source 
[https://github.com/pret/pokecrystal/issues/1078#issue-1869550979 and https://github.com/pret/pokecrystal/issues/1078#issuecomment-1696394371]
This commit is contained in:
xCrystal
2024-01-07 12:38:00 +01:00
parent dbf6044650
commit bd6ceec193
107 changed files with 340 additions and 337 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/pokemon/bills_pc_top.asm
View File

@@ -48,7 +48,7 @@ _BillsPC:
ld a, $1
.loop
ld [wMenuCursorPosition], a
call SetPalettes
call SetDefaultBGPAndOBP
xor a
ld [wWhichIndexSet], a
ldh [hBGMapMode], a
@@ -245,7 +245,7 @@ ClearPCItemScreen:
lb bc, 4, 18
call Textbox
call WaitBGMap2
call SetPalettes ; load regular palettes?
call SetDefaultBGPAndOBP
ret
CopyBoxmonToTempMon:

2
engine/pokemon/breeding.asm
View File

@@ -659,7 +659,7 @@ Hatch_UpdateFrontpicBGMapCenter:
predef PlaceGraphic
pop af
call Hatch_LoadFrontpicPal
call SetPalettes
call SetDefaultBGPAndOBP
jp WaitBGMap
EggHatch_DoAnimFrame:

2
engine/pokemon/mail.asm
View File

@@ -490,7 +490,7 @@ MailboxPC:
farcall WritePartyMenuTilemap
farcall PrintPartyMenuText
call WaitBGMap
call SetPalettes
call SetDefaultBGPAndOBP
call DelayFrame
farcall PartyMenuSelect
jr c, .exit2

2
engine/pokemon/mail_2.asm
View File

@@ -53,7 +53,7 @@ ReadAnyMail:
ld a, [wCurMailIndex]
ld e, a
farcall LoadMailPalettes
call SetPalettes
call SetDefaultBGPAndOBP
xor a
ldh [hJoyPressed], a
call .loop

4
engine/pokemon/mon_menu.asm
View File

@@ -173,7 +173,7 @@ SwitchPartyMons:
call AddNTimes
ld [hl], "▷"
call WaitBGMap
call SetPalettes
call SetDefaultBGPAndOBP
call DelayFrame
farcall PartyMenuSelect
@@ -1151,7 +1151,7 @@ SetUpMoveList:
hlcoord 10, 4
predef ListMovePP
call WaitBGMap
call SetPalettes
call SetDefaultBGPAndOBP
ld a, [wNumMoves]
inc a
ld [w2DMenuNumRows], a

4
engine/pokemon/party_menu.asm
View File

@@ -5,7 +5,7 @@ SelectMonFromParty:
call ClearBGPalettes
call InitPartyMenuLayout
call WaitBGMap
call SetPalettes
call SetDefaultBGPAndOBP
call DelayFrame
call PartyMenuSelect
call ReturnToMapWithSpeechTextbox
@@ -20,7 +20,7 @@ SelectTradeOrDayCareMon:
call WaitBGMap
ld b, SCGB_PARTY_MENU
call GetSGBLayout
call SetPalettes
call SetDefaultBGPAndOBP
call DelayFrame
call PartyMenuSelect
call ReturnToMapWithSpeechTextbox

10
engine/pokemon/stats_screen.asm
View File

@@ -533,7 +533,7 @@ StatsScreen_LoadGFX:
ld hl, wStatsScreenFlags
bit 4, [hl]
jr nz, .place_frontpic
call SetPalettes
call SetDefaultBGPAndOBP
ret
.place_frontpic
@@ -834,16 +834,16 @@ StatsScreen_PlaceFrontpic:
.egg
call .AnimateEgg
call SetPalettes
call SetDefaultBGPAndOBP
ret
.no_cry
call .AnimateMon
call SetPalettes
call SetDefaultBGPAndOBP
ret
.cry
call SetPalettes
call SetDefaultBGPAndOBP
call .AnimateMon
ld a, [wCurPartySpecies]
call PlayMonCry2
@@ -1037,7 +1037,7 @@ endc
call PlaceString
ld hl, wStatsScreenFlags
set 5, [hl]
call SetPalettes ; pals
call SetDefaultBGPAndOBP
call DelayFrame
hlcoord 0, 0
call PrepMonFrontpic