sprite engine; tileset constants

engine/color.asm

@@ -318,7 +318,7 @@ Function8bec: ; 8bec
 	lb bc, 6, 4
 	ld a, [EnemySafeguardCount]
 	and $3
-	call Function9663
+	call FillBoxCGB
 	call LoadDETile
 	ret
 ; 8c1d
@@ -394,7 +394,7 @@ endr
 .asm_8c82
 	lb bc, 2, 8
 	ld a, e
-	call Function9663
+	call FillBoxCGB
 	ret
 ; 8c8a
 
@@ -618,7 +618,7 @@ Function9643: ; 9643
 	ret
 ; 9663
 
-Function9663: ; 9663
+FillBoxCGB: ; 9663
 .row
 	push bc
 	push hl
@@ -752,7 +752,7 @@ Function96f3: ; 96f3
 .asm_9712
 	lb bc, 2, 8
 	ld a, e
-	call Function9663
+	call FillBoxCGB
 	ret
 ; 971a
 

engine/engine_flags.asm

@@ -22,7 +22,7 @@ ENDM
 	engine_flag wMomSavingMoney, 0 ; mom saving money ; $8
 	engine_flag wMomSavingMoney, 7 ; dst
 
-	engine_flag wdc39, 0
+	engine_flag wdc39, 0 ; unused, possibly related to a 2-day timer
 
 	engine_flag StatusFlags, 0 ; pokedex
 	engine_flag StatusFlags, 1 ; unown dex
@@ -31,7 +31,7 @@ ENDM
 	engine_flag StatusFlags, 6 ; credits skip
 	engine_flag StatusFlags, 7 ; bug contest on   ; $10
 	engine_flag StatusFlags2, 2 ; bug contest timer
-	engine_flag StatusFlags2, 1
+	engine_flag StatusFlags2, 1 ; ???
 	engine_flag StatusFlags2, 0 ; rockets in radio tower
 	engine_flag StatusFlags2, 4 ; bike shop call enabled (1024 bike steps reqd)
 	engine_flag StatusFlags2, 5 ; give pokerus
@@ -71,14 +71,14 @@ ENDM
 	engine_flag UnlockedUnowns, 7 ; 8
 
 	; fly
-	engine_flag VisitedSpawns, 0 ; your house
-	engine_flag VisitedSpawns, 1 ; viridian pokecenter
-	engine_flag VisitedSpawns, 2 ; pallet
-	engine_flag VisitedSpawns, 3 ; viridian
-	engine_flag VisitedSpawns, 4 ; pewter
-	engine_flag VisitedSpawns, 5 ; cerulean ; $38
-	engine_flag VisitedSpawns, 6 ; rock tunnel
-	engine_flag VisitedSpawns, 7 ; vermilion
+	engine_flag VisitedSpawns, 0     ; your house
+	engine_flag VisitedSpawns, 1     ; viridian pokecenter
+	engine_flag VisitedSpawns, 2     ; pallet
+	engine_flag VisitedSpawns, 3     ; viridian
+	engine_flag VisitedSpawns, 4     ; pewter
+	engine_flag VisitedSpawns, 5     ; cerulean ; $38
+	engine_flag VisitedSpawns, 6     ; rock tunnel
+	engine_flag VisitedSpawns, 7     ; vermilion
 	engine_flag VisitedSpawns + 1, 0 ; lavender
 	engine_flag VisitedSpawns + 1, 1 ; saffron
 	engine_flag VisitedSpawns + 1, 2 ; celadon
@@ -88,6 +88,7 @@ ENDM
 	engine_flag VisitedSpawns + 1, 6 ; new bark
 	engine_flag VisitedSpawns + 1, 7 ; cherrygrove
 	engine_flag VisitedSpawns + 2, 0 ; violet
+	                                 ; union cave
 	engine_flag VisitedSpawns + 2, 2 ; azalea
 	engine_flag VisitedSpawns + 2, 3 ; cianwood
 	engine_flag VisitedSpawns + 2, 4 ; goldenrod
@@ -97,6 +98,7 @@ ENDM
 	engine_flag VisitedSpawns + 3, 0 ; lake of rage
 	engine_flag VisitedSpawns + 3, 1 ; blackthorn
 	engine_flag VisitedSpawns + 3, 2 ; silver cave
+	                                 ; fast ship
 	engine_flag VisitedSpawns + 3, 4 ; unused
 
 	engine_flag wLuckyNumberShowFlag, 0 ; lucky number show
@@ -157,7 +159,7 @@ ENDM
 
 	engine_flag wDailyPhoneItemFlags, 0 ; beverly has nugget
 	engine_flag wDailyPhoneItemFlags, 1 ; jose has star piece
-	engine_flag wDailyPhoneItemFlags, 2 ; wade has item (see bittable1 $032b-e)
+	engine_flag wDailyPhoneItemFlags, 2 ; wade has item (see EVENT_WADE_HAS_*** in constants/event_flags.asm)
 	engine_flag wDailyPhoneItemFlags, 3 ; gina has leaf stone  ; $80
 	engine_flag wDailyPhoneItemFlags, 4 ; alan has fire stone
 	engine_flag wDailyPhoneItemFlags, 5 ; liz has thunderstone
@@ -165,7 +167,7 @@ ENDM
 	engine_flag wDailyPhoneItemFlags, 7 ; tully has water stone
 
 	engine_flag wDailyPhoneItemFlags + 1, 0 ; tiffany has pink bow
-	engine_flag wDailyPhoneItemFlags + 1, 1 ; wilton has item (see bittable1 $032f-31)
+	engine_flag wDailyPhoneItemFlags + 1, 1 ; wilton has item (see EVENT_WILTON_HAS_*** in constants/event_flags.asm)
 
 	engine_flag wDailyPhoneTimeOfDayFlags, 0
 	engine_flag wDailyPhoneTimeOfDayFlags, 1  ; $88

engine/events.asm

@@ -511,7 +511,7 @@ CheckTimeEvents: ; 9693a
 	jr nz, .nothing
 
 	ld hl, StatusFlags2
-	bit 2, [hl]
+	bit 2, [hl] ; bug contest
 	jr z, .do_daily
 
 	callba CheckBugContestTimer

engine/events_2.asm

@@ -3,8 +3,8 @@
 
 WarpToSpawnPoint:: ; 97c28
 	ld hl, StatusFlags2
-	res 1, [hl]
-	res 2, [hl]
+	res 1, [hl] ; ??
+	res 2, [hl] ; bug contest
 	ret
 ; 97c30
 

engine/flypoints.asm

@@ -496,7 +496,7 @@ Function91d9b: ; 91d9b
 
 .asm_91db7
 	ld a, [StatusFlags]
-	bit 6, a
+	bit 6, a ; hall of fame
 	ret z
 	ld a, [hWY]
 	and a

engine/map_objects.asm

@@ -717,7 +717,7 @@ Function46a6: ; 46a6
 	ld e, a
 
 	push bc
-	call Function2a3c
+	call GetCoordTile
 	pop bc
 
 	ld hl, OBJECT_STANDING_TILE
@@ -922,7 +922,7 @@ Function47bc: ; 47bc
 	add hl, bc
 	ld e, [hl]
 	push bc
-	call Function2a3c
+	call GetCoordTile
 	pop bc
 	ld hl, OBJECT_STANDING_TILE
 	add hl, bc
@@ -2874,7 +2874,7 @@ Function5688: ; 5688
 	ld hl, OBJECT_MAP_Y
 	add hl, bc
 	ld e, [hl]
-	call Function2a3c
+	call GetCoordTile
 	pop bc
 	ld hl, OBJECT_STANDING_TILE
 	add hl, bc

engine/pokedex.asm

@@ -65,12 +65,8 @@ InitPokedex: ; 40063
 	call ClearTileMap
 	call Function414b7
 
-	ld hl, wc6d0
-IF DEF(CRYSTAL11)
-	ld bc, $0116
-ELSE
-	ld bc, $0115
-ENDC
+	ld hl, wPokedexDataStart
+	ld bc, wPokedexDataEnd - wPokedexDataStart
 	xor a
 	call ByteFill