Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix inaccurate denotations to the concepts of tile, tile collision, and collision permission (#1078)

Browse Source
This commit is contained in:
xCrystal
2024-01-07 14:51:27 +01:00
parent 7f3b87950a
commit e0c278a595
17 changed files with 76 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
home/map_objects.asm
View File

@@ -71,34 +71,34 @@ DoesSpriteHaveFacings::
pop de
ret
GetPlayerTile::
ld a, [wPlayerTile]
call GetTileCollision
GetPlayerTilePermission::
ld a, [wPlayerTileCollision]
call GetTilePermission
ld b, a
ret
CheckOnWater::
ld a, [wPlayerTile]
call GetTileCollision
ld a, [wPlayerTileCollision]
call GetTilePermission
sub WATER_TILE
ret z
and a
ret
GetTileCollision::
; Get the collision type of tile a.
GetTilePermission::
; Get the permission of tile collision a.
push de
push hl
ld hl, TileCollisionTable
ld hl, CollisionPermissionTable
ld e, a
ld d, 0
add hl, de
ldh a, [hROMBank]
push af
ld a, BANK(TileCollisionTable)
ld a, BANK(CollisionPermissionTable)
rst Bankswitch
ld e, [hl]
pop af
@@ -189,7 +189,7 @@ CheckWaterfallTile::
ret
CheckStandingOnEntrance::
ld a, [wPlayerTile]
ld a, [wPlayerTileCollision]
cp COLL_DOOR
ret z
cp COLL_DOOR_79