Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use labels instead of constants for HRAM

Browse Source 
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
This commit is contained in:
Rangi
2018-08-25 14:28:22 -04:00
parent 376c64468b
commit eb1e3636bb
243 changed files with 4706 additions and 4661 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
engine/printer/printer_serial.asm
View File

@@ -4,8 +4,8 @@ Printer_StartTransmission:
xor a
call Printer_ByteFill
xor a
ld [rSB], a
ld [rSC], a
ldh [rSB], a
ldh [rSC], a
ld [wPrinterOpcode], a
ld hl, wPrinterConnectionOpen
set 0, [hl]
@@ -278,11 +278,11 @@ Printer_WaitHandshake:
ld a, $1
ld [wPrinterOpcode], a
ld a, $88
ld [rSB], a
ldh [rSB], a
ld a, $1
ld [rSC], a
ldh [rSC], a
ld a, $81
ld [rSC], a
ldh [rSC], a
ret
Printer_CopyPacket:
@@ -588,7 +588,7 @@ Printer_Send0x00_2:
ret
Printer_ReceiveTwoPrinterHandshakeAndSend0x00:
ld a, [rSB]
ldh a, [rSB]
ld [wPrinterHandshake], a
ld a, $0
call Printer_SerialSend
@@ -596,7 +596,7 @@ Printer_ReceiveTwoPrinterHandshakeAndSend0x00:
ret
Printer_ReceiveTwoPrinterStatusFlagsAndExitSendLoop:
ld a, [rSB]
ldh a, [rSB]
ld [wPrinterStatusFlags], a
xor a
ld [wPrinterOpcode], a
@@ -621,16 +621,16 @@ Printer_Send0x08:
ret
Printer_SerialSend:
ld [rSB], a
ldh [rSB], a
ld a, $1 ; switch to internal clock
ld [rSC], a
ldh [rSC], a
ld a, $81 ; start transfer
ld [rSC], a
ldh [rSC], a
ret
Printer_ReceiveTwoPrinterStatusFlagsAndExitSendLoop_2:
; identical to Printer_ReceiveTwoPrinterStatusFlagsAndExitSendLoop, but referenced less
ld a, [rSB]
ldh a, [rSB]
ld [wPrinterStatusFlags], a
xor a
ld [wPrinterOpcode], a