Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Meaningful scene constant names

Browse Source 
(Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event)
This commit is contained in:
Rangi
2018-02-01 12:40:58 -05:00
parent 936a170e0d
commit fcfe77bc3d
85 changed files with 596 additions and 678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
maps/AzaleaTown.asm
View File

@@ -14,9 +14,9 @@
AzaleaTown_MapScripts:
db 3 ; scene scripts
scene_script .DummyScene0 ; SCENE_AZALEATOWN_0
scene_script .DummyScene1 ; SCENE_AZALEATOWN_1
scene_script .DummyScene2 ; SCENE_AZALEATOWN_2
scene_script .DummyScene0 ; SCENE_AZALEATOWN_NOTHING
scene_script .DummyScene1 ; SCENE_AZALEATOWN_RIVAL_BATTLE
scene_script .DummyScene2 ; SCENE_AZALEATOWN_KURT_RETURNS_GS_BALL
db 1 ; callbacks
callback MAPCALLBACK_NEWMAP, .Flypoint
@@ -100,7 +100,7 @@ AzaleaTownRivalBattleScript:
applymovement AZALEATOWN_SILVER, AzaleaTownRivalBattleExitMovement
playsound SFX_EXIT_BUILDING
disappear AZALEATOWN_SILVER
setscene SCENE_AZALEATOWN_0
setscene SCENE_AZALEATOWN_NOTHING
waitsfx
playmapmusic
end
@@ -168,7 +168,7 @@ AzaleaTownCelebiScene:
setflag ENGINE_FOREST_IS_RESTLESS
clearevent EVENT_ILEX_FOREST_LASS
setevent EVENT_ROUTE_34_ILEX_FOREST_GATE_LASS
setscene SCENE_AZALEATOWN_0
setscene SCENE_AZALEATOWN_NOTHING
closetext
end
@@ -467,9 +467,9 @@ AzaleaTown_MapEvents:
warp_event 2, 11, 4, ILEX_FOREST_AZALEA_GATE
db 3 ; coord events
coord_event 5, 10, SCENE_AZALEATOWN_1, AzaleaTownRivalBattleScene1
coord_event 5, 11, SCENE_AZALEATOWN_1, AzaleaTownRivalBattleScene2
coord_event 9, 6, SCENE_AZALEATOWN_2, AzaleaTownCelebiScene
coord_event 5, 10, SCENE_AZALEATOWN_RIVAL_BATTLE, AzaleaTownRivalBattleScene1
coord_event 5, 11, SCENE_AZALEATOWN_RIVAL_BATTLE, AzaleaTownRivalBattleScene2
coord_event 9, 6, SCENE_AZALEATOWN_KURT_RETURNS_GS_BALL, AzaleaTownCelebiScene
db 9 ; bg events
bg_event 19, 9, BGEVENT_READ, AzaleaTownSign