Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Meaningful scene constant names

Browse Source 
(Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event)
This commit is contained in:
Rangi
2018-02-01 12:40:58 -05:00
parent 936a170e0d
commit fcfe77bc3d
85 changed files with 596 additions and 678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
maps/IndigoPlateauPokecenter1F.asm
View File

@@ -8,7 +8,7 @@
IndigoPlateauPokecenter1F_MapScripts:
db 1 ; scene scripts
scene_script .DummyScene ; SCENE_INDIGOPLATEAUPOKECENTER1F_0
scene_script .DummyScene ; SCENE_DEFAULT
db 1 ; callbacks
callback MAPCALLBACK_NEWMAP, .PrepareElite4
@@ -17,12 +17,12 @@ IndigoPlateauPokecenter1F_MapScripts:
end
.PrepareElite4:
setmapscene WILLS_ROOM, SCENE_WILLSROOM_0
setmapscene KOGAS_ROOM, SCENE_KOGASROOM_0
setmapscene BRUNOS_ROOM, SCENE_BRUNOSROOM_0
setmapscene KARENS_ROOM, SCENE_KARENSROOM_0
setmapscene LANCES_ROOM, SCENE_LANCESROOM_0
setmapscene HALL_OF_FAME, SCENE_HALLOFFAME_0
setmapscene WILLS_ROOM, SCENE_DEFAULT
setmapscene KOGAS_ROOM, SCENE_DEFAULT
setmapscene BRUNOS_ROOM, SCENE_DEFAULT
setmapscene KARENS_ROOM, SCENE_DEFAULT
setmapscene LANCES_ROOM, SCENE_DEFAULT
setmapscene HALL_OF_FAME, SCENE_DEFAULT
clearevent EVENT_WILLS_ROOM_ENTRANCE_CLOSED
clearevent EVENT_WILLS_ROOM_EXIT_OPEN
clearevent EVENT_KOGAS_ROOM_ENTRANCE_CLOSED
@@ -128,7 +128,7 @@ PlateauRivalPostBattle:
spriteface PLAYER, DOWN
applymovement INDIGOPLATEAUPOKECENTER1F_SILVER, PlateauRivalLeavesMovement
disappear INDIGOPLATEAUPOKECENTER1F_SILVER
setscene SCENE_INDIGOPLATEAUPOKECENTER1F_0
setscene SCENE_DEFAULT
playmapmusic
setflag ENGINE_INDIGO_PLATEAU_RIVAL_FIGHT
PlateauRivalScriptDone:
@@ -310,8 +310,8 @@ IndigoPlateauPokecenter1F_MapEvents:
warp_event 14, 3, 1, WILLS_ROOM
db 2 ; coord events
coord_event 16, 4, SCENE_INDIGOPLATEAUPOKECENTER1F_0, PlateauRivalBattle1
coord_event 17, 4, SCENE_INDIGOPLATEAUPOKECENTER1F_0, PlateauRivalBattle2
coord_event 16, 4, SCENE_DEFAULT, PlateauRivalBattle1
coord_event 17, 4, SCENE_DEFAULT, PlateauRivalBattle2
db 0 ; bg events