Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Meaningful scene constant names

Browse Source 
(Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event)
This commit is contained in:
Rangi
2018-02-01 12:40:58 -05:00
parent 936a170e0d
commit fcfe77bc3d
85 changed files with 596 additions and 678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
maps/Route32.asm
View File

@@ -16,9 +16,9 @@
Route32_MapScripts:
db 3 ; scene scripts
scene_script .DummyScene0 ; SCENE_ROUTE32_0
scene_script .DummyScene1 ; SCENE_ROUTE32_1
scene_script .DummyScene2 ; SCENE_ROUTE32_2
scene_script .DummyScene0 ; SCENE_DEFAULT
scene_script .DummyScene1 ; SCENE_ROUTE32_OFFER_SLOWPOKETAIL
scene_script .DummyScene2 ; SCENE_ROUTE32_NOTHING
db 1 ; callbacks
callback MAPCALLBACK_OBJECTS, .Frieda
@@ -125,7 +125,7 @@ Route32WannaBuyASlowpokeTailScript:
SlowpokeTailSalesmanScript:
faceplayer
_OfferToSellSlowpokeTail:
setscene SCENE_ROUTE32_2
setscene SCENE_ROUTE32_NOTHING
opentext
writetext Text_MillionDollarSlowpokeTail
yesorno
@@ -936,8 +936,8 @@ Route32_MapEvents:
warp_event 6, 79, 4, UNION_CAVE_1F
db 2 ; coord events
coord_event 18, 8, SCENE_ROUTE32_0, Route32CooltrainerMStopsYouScene
coord_event 7, 71, SCENE_ROUTE32_1, Route32WannaBuyASlowpokeTailScript
coord_event 18, 8, SCENE_DEFAULT, Route32CooltrainerMStopsYouScene
coord_event 7, 71, SCENE_ROUTE32_OFFER_SLOWPOKETAIL, Route32WannaBuyASlowpokeTailScript
db 6 ; bg events
bg_event 13, 5, BGEVENT_READ, Route32Sign