Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Meaningful scene constant names

Browse Source 
(Two common patterns: 0=default event and 1=nothing; and 0=nothing and 1=some event)
This commit is contained in:
Rangi
2018-02-01 12:40:58 -05:00
parent 936a170e0d
commit fcfe77bc3d
85 changed files with 596 additions and 678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
maps/RuinsOfAlphOutside.asm
View File

@@ -7,8 +7,8 @@
RuinsOfAlphOutside_MapScripts:
db 2 ; scene scripts
scene_script .DummyScene0 ; SCENE_RUINSOFALPHOUTSIDE_0
scene_script .DummyScene1 ; SCENE_RUINSOFALPHOUTSIDE_1
scene_script .DummyScene0 ; SCENE_RUINSOFALPHOUTSIDE_NOTHING
scene_script .DummyScene1 ; SCENE_RUINSOFALPHOUTSIDE_GET_UNOWN_DEX
db 1 ; callbacks
callback MAPCALLBACK_OBJECTS, .ScientistCallback
@@ -33,12 +33,12 @@ RuinsOfAlphOutside_MapScripts:
.YesScientist:
appear RUINSOFALPHOUTSIDE_SCIENTIST
setscene SCENE_RUINSOFALPHOUTSIDE_1
setscene SCENE_RUINSOFALPHOUTSIDE_GET_UNOWN_DEX
return
.NoScientist:
disappear RUINSOFALPHOUTSIDE_SCIENTIST
setscene SCENE_RUINSOFALPHOUTSIDE_0
setscene SCENE_RUINSOFALPHOUTSIDE_NOTHING
return
RuinsOfAlphOutsideScientistScene1:
@@ -64,7 +64,7 @@ UnknownScript_0x58044:
disappear RUINSOFALPHOUTSIDE_SCIENTIST
stopfollow
applymovement PLAYER, MovementData_0x580c5
setmapscene RUINS_OF_ALPH_RESEARCH_CENTER, SCENE_RUINSOFALPHRESEARCHCENTER_1
setmapscene RUINS_OF_ALPH_RESEARCH_CENTER, SCENE_RUINSOFALPHRESEARCHCENTER_GET_UNOWN_DEX
warpcheck
end
@@ -295,8 +295,8 @@ RuinsOfAlphOutside_MapEvents:
warp_event 13, 21, 2, ROUTE_32_RUINS_OF_ALPH_GATE
db 2 ; coord events
coord_event 11, 14, SCENE_RUINSOFALPHOUTSIDE_1, RuinsOfAlphOutsideScientistScene1
coord_event 10, 15, SCENE_RUINSOFALPHOUTSIDE_1, RuinsOfAlphOutsideScientistScene2
coord_event 11, 14, SCENE_RUINSOFALPHOUTSIDE_GET_UNOWN_DEX, RuinsOfAlphOutsideScientistScene1
coord_event 10, 15, SCENE_RUINSOFALPHOUTSIDE_GET_UNOWN_DEX, RuinsOfAlphOutsideScientistScene2
db 3 ; bg events
bg_event 16, 8, BGEVENT_READ, RuinsOfAlphOutsideSignpost0Script