Commit Graph

5222 Commits

Author SHA1 Message Date
Idain
2907d65a47 Improve use of palette macro and use PAL_* constants (#1087)
* Improve use of palette macro and use PAL_* constants

* Use proper constant for battle stats (#1088)

* Add suggestions about function names and variables

* Add colors macro

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:24:09 -06:00
SnorlaxMonster
75f0ad3955 Correct macro for default Mystery Gift item (#1084)
Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-11-17 12:18:49 -06:00
Idain
3866716980 Use proper constant for battle stats (#1088) 2023-10-23 14:06:04 -05:00
vulcandth
aba1f14044 Sync sprite and battle anim consts/labels (#1055)
* Sync sprite and battle anim consts/labels

* Add `; 00` comments

* Renamed to `SpriteAnimFunc_` and `BattleAnimFunc_`
2023-09-17 13:09:28 -05:00
Tiddlywinks
b0ddb0758d 1) Fix DECOFLAG order. 2) The doll is Staryu, not Starmie (and the sprite can be either) 2023-09-13 08:08:27 +02:00
vulcandth
0b91f5c656 CI copy .map files to symbols branch 2023-08-22 18:47:12 -05:00
SoupPotato
6180be355e Labeled framesets and related constants (#1063)
* Labeled Framesets and Constants Related

* Feedback Implemented with PascalCase and Constant Renames

* Fix framset.asm comment spacing

* `BATTLEANIMFRAMESET_35` to `BATTLEANIMFRAMESET_THUNDER_WAVE_EXTRA`

* Feedback applied and labeled 1E & B2

* Fixed SpinningBone

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-08-21 19:09:23 -05:00
Idain
5db85badf8 Replace hardcoded numbers for stats (#1073) 2023-08-21 10:53:32 -05:00
AnonymousRandomPerson
fceffda367 Added newer decomp projects to readme 2023-08-19 13:30:32 +00:00
Rangi
0d899cbd3b Define all unused type names with rept (#1071)
Fixes #1070
2023-08-16 10:22:35 -04:00
Rangi
f3b31087e3 Use MAP_CONNECTION_PADDING_WIDTH in MACRO connection
Fixes #1033
2023-08-15 19:54:16 -04:00
Rangi
9c0ef02d4b Verify that there aren't too many OAM constants
Fixes #1062
2023-08-15 19:45:33 -04:00
Rangi
df05357a4d Add dupeframes.py tool to find duplicate animated Pokémon frames
Fixes #1067
2023-08-15 19:34:16 -04:00
Rangi
a5c36a72c4 Avoid goto, support '\r', and fix typo in scan_includes.c 2023-08-15 19:19:15 -04:00
Lorenzooone
8e71632536 Fix segfaults at EOF for scan_includes, and add token/newline checks (#1068) 2023-08-14 12:12:00 -04:00
vulcandth
e07a1e7773 Define relationship between map_object and object_events (#1054) 2023-08-14 09:19:25 -05:00
Idain
6926900f0f Document fix about AI item pointer overflowing (#1066) 2023-08-10 13:29:03 -04:00
SatoMew
768b3bdec1 Improve mobile-related labels (#1061) 2023-07-26 19:59:00 -05:00
SnorlaxMonster
c931b98a81 Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058)
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
2023-07-26 19:51:34 -05:00
Idain
94df3c5aa3 Replace magic numbers with TILE_WIDTH (#1056)
* Replace magic numbers with TILE_WIDTH

* Address more instances
2023-07-26 19:50:16 -05:00
Idain
1d64befdb7 Replace magic number with TEXTBOX_FRAME_TILES (#1057) 2023-07-18 08:58:37 -05:00
vulcandth
31c55dc74d Use BattleAnim_Dummy in data/moves/animations.asm (#1052) 2023-06-22 16:15:43 -04:00
vulcandth
438c48daad Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
Idain
5e983d32aa Use NO_INPUT instead of magic number (#1051)
This is for the Virtual Console builds, where it disables the print functions of Unown and Mail.
2023-05-28 09:12:33 -05:00
mid-kid
5e8c7c8f78 Fix tools/free_space.awk for new rgbds (#1049) 2023-05-17 09:18:18 -05:00
Idain
8c6242a152 Fix macro definitiosn for unused commands 2023-05-06 20:12:45 -04:00
mid-kid
354fefaefb Use time capsule label for time capsule copies 2023-04-19 19:12:14 +02:00
mid-kid
a1e711b80d Use more appropriate labels for link operations 2023-04-19 19:12:14 +02:00
mid-kid
4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid
5ae35e5770 Label wOTLinkBattleRNData 2023-04-19 19:12:14 +02:00
mid-kid
08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid
2fc7d17851 Unionize wSwitchMonBuffer 2023-04-19 19:12:14 +02:00
mid-kid
c8e9a82190 Make wMysteryGift*GameVersion constants consistent 2023-04-19 19:12:14 +02:00
mid-kid
a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00
Damien Doury
1674b6ca5a Fixed the wrong CheckHiddenOpponent bugfix (#1046) 2023-04-06 12:05:59 -04:00
vulcandth
06dd208cc7 Update EndBug to v9.
fixes #1038
2023-04-01 13:56:21 -05:00
vulcandth
c75d121c78 Missed DEF in add_tm 2023-03-16 21:25:33 -05:00
mid-kid
cfd432f468 Minor battle tower fixes 2023-03-08 13:52:47 +01:00
mid-kid
cf1c505555 GetNicknamenamePointer -> GetNicknamePointer
Found this commit on an old drive
2023-02-26 12:28:06 +01:00
mid-kid
18efb2fab3 Document scripting engine fix for MBC30 2023-02-25 11:52:44 +01:00
Andrew Cook
0aadbec02a Label indirect access to rIE in lib/mobile 2023-02-21 19:50:36 +01:00
vulcandth
c01409be5a Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
Daniel Harding
2d40e99d11 Ensure linked songs are in the same bank (#1027) 2022-12-29 07:59:32 -06:00
Rangi
ce99c9e93c Use rgbgfx -c embedded to extract palettes
Fixes #1026
2022-12-27 18:34:46 -05:00
vulcandth
cb8505e022 Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391 wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
vulcandth
f739f8b1ac Add table assert DoBattleAnimFrame.Jumptable 2022-12-23 18:48:14 -06:00
Rangi
4387298b2c Comment the Crystal 1.0 bugs as "BUG:" too 2022-12-14 22:30:20 -05:00
Rangi
8fd66c080f Use rgbds 0.6.1 (0.6.0 also still works) 2022-12-03 11:11:20 -05:00
Rangi
eb28b5ae56 Only patch Stadium data for a 2MB ROM 2022-12-03 11:10:55 -05:00