Future/pokecrystal
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,104 Commits 1 Branch 0 Tags
c931b98a8144b4d5c5bce8444ffc658ddf41ffd7
Commit Graph

686 Commits

Author SHA1 Message Date
SnorlaxMonster
c931b98a81 Rename BATTLETYPE_SHINY to BATTLETYPE_FORCESHINY (#1058) 
* Rename BATTLETYPE_SHINY to BATTLETYPE_FORCED_SHINY

The name BATTLETYPE_SHINY gave the impression that it applied to all
battles with Shiny Pokémon, rather than merely battles with forced
Shiny Pokémon (i.e. Red Gyarados only).

* Rename to BATTLETYPE_FORCESHINY

Align name of BATTLETYPE with BATTLETYPE_FORCEITEM

---------

Co-authored-by: SnorlaxMonster <snorlaxmonster@users.noreply.github.com>
 2023-07-26 19:51:34 -05:00
vulcandth
438c48daad Rename PAL_NPC_SILVER to PAL_NPC_EMOTE (#1053) 2023-06-01 07:47:53 -05:00
mid-kid
4c4fd7258c Define SERIAL_PATCH_PREAMBLE_LENGTH 2023-04-19 19:12:14 +02:00
mid-kid
08cfbbb1d9 Document link patch lists a little bit better 2023-04-19 19:12:14 +02:00
mid-kid
a6ac67dea2 IsMailEuropean → ParseMailLanguage (and give it constants) 2023-04-19 19:12:14 +02:00
vulcandth
c75d121c78 Missed DEF in add_tm 2023-03-16 21:25:33 -05:00
vulcandth
c01409be5a Relabel some map_object struct fields (#1029) 2023-01-03 22:16:08 -05:00
vulcandth
cb8505e022 Define InitDefaultEZChatMsgs and sEZChatMessages (#1022) 2022-12-26 13:55:01 -05:00
vulcandth
25e12c9391 wUnlockedUnowns engine_flag constants (#1025) 2022-12-26 13:14:10 -05:00
Rangi
8fc3b8e6e3 Dance Theatre -> Dance Theater 
Fixes #1008
 2022-09-23 22:06:52 -04:00
Idain
553a272e52 TYPO: NUM_MOVE_EFECTS > NUM_MOVE_EFFECTS (#1009) 2022-09-21 22:01:39 -05:00
Rangi
711f5c87b3 Comment about the redundant event const_next 1900 
Fixes #1006
 2022-09-15 18:05:52 -04:00
Andrew Cook
0f5540740b Some Mobile code labeling and removed magic numbers (#993) 
* Macro loop for EmptyAllSRAMBanks

* Many things labeled and magic numbers removed

* Conform to the style guide

* Rename URLs in mobile_46

* MOBILEAPI_19 -> MOBILEAPI_TELEPHONESTATUS

* Update engine/menus/empty_sram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update ram/wram.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Update mobile/mobile_46.asm

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>

* Remove underscore from Set*DownloadURL symbols

* Begin Labeling TradeCornerHoldMon routines

* Add wMobileMon party_struct

* Add TRADE_CORNER_REQUEST_LENGTH constant

* Name battle tower action functions

* Label trade corner send/receive buffer

* Label the saved copy of the trade corner pokemon

also fix mailmsg_jp

* So many copies of decodeBase64Character

* Label another buffer

* Fix Alignment and use MOBILE_EMAIL_LENGTH

* `Function11ad8a` -> `MobileIncJumptableIndex`

* Apply Rangi Suggestions pass 1

Co-Authored-By: Rangi <35663410+Rangi42@users.noreply.github.com>

* Apply Suggestions 2

Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: vulcandth <vulcandth@gmail.com>
 2022-09-14 19:49:58 -05:00
Rangi
41d5ea0482 Rename the object_struct field labels and constants (#1005) 
Fixes #990
 2022-09-12 09:15:44 -04:00
vulcandth
4c239a6f65 Rename macros/wram.asm to macros/ram.asm (#1003) 2022-09-11 01:05:07 -04:00
Rangi
0d5cf5c8b9 Refer to "Rival", not "Silver" (#983) 
Fixes #982
 2022-08-10 21:24:56 -04:00
vulcandth
c3331eb7b1 Rename scene and callback labels (#981) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-08-09 18:04:18 -04:00
Rangi
8826d97ee4 Define scene constants alongside scene_scripts (#979) 
Generic SCENE_DEFAULT and SCENE_FINISHED are legacy values
 2022-07-29 17:43:10 -04:00
Colton G. Rushton
145d8dd5c2 wVirtualOAM -> wShadowOAM and hTransferVirtualOAM -> hTransferShadowOAM (#971) 2022-07-09 17:18:22 -04:00
Colton G. Rushton
d3da137de8 Add object priority mode constant and remove unnecessary constants (#972) 
The rest of the unknown constants aren't even registers and can safely be removed without issue.
 2022-07-04 01:10:24 -04:00
Colton G. Rushton
4125138da7 Remove unused serial constants ported from pokered (#949) 2022-06-18 13:33:34 -04:00
Colton G. Rushton
6a9e929bf9 Remove rNR20/rNR40 and add rPCM12/rPCM34 (#947) 2022-06-17 22:29:09 -04:00
vulcandth
5f0597e944 Rename SLP to SLP_MASK (#918) 
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
 2022-06-17 22:25:56 -04:00
vulcandth
3648afda16 RGBDS syntax updates (#905) 
New MACRO and DEF syntax
 2022-06-06 17:25:42 -04:00
Idain
d0c8f63f25 Rename ENGINE_FISH_SWARM to ENGINE_QWILFISH_SWARM (#879) 2022-02-22 09:47:05 -05:00
Rangi
13837b429c Define the *_WILDDATA_LENGTH equations to match their data representation 2022-02-12 10:01:12 -05:00
mid-kid
1dc88cb585 Enumerate MobileAPI function constants 2022-01-23 18:13:41 +00:00
Rangi
69185e1657 Identify some overworld movement data 2021-12-22 21:38:26 -05:00
Rangi
9042b8f83d Swimmer♀ Mary is unused 2021-11-28 11:39:46 -05:00
Rangi
ab0f9c287a Use compound assignment operators 2021-11-23 20:18:08 -05:00
Rangi
645719e99b Comment unused trainers 
Fixes #819
 2021-11-03 19:33:54 -04:00
Rangi
187b120007 Add assertions to some more tables 2021-10-24 18:28:54 -04:00
Rangi
f59f1bdb88 Standardize capitalization of ".Jumptable" 2021-06-19 19:52:05 -04:00
Rangi
1f9e688b76 MON_PKRUS -> MON_POKERUS 2021-06-07 20:00:21 -04:00
Rangi
ed0a0f7159 Move the dbbw, dbww, and dbwww macros to legacy 2021-05-30 15:51:49 -04:00
Rangi
efd1006917 Use {interpolation} to generate sequences of RAM labels 
This makes the table_width/assert_table_length usages unnecessary, and also keeps the labels automatically up to date if the length constants change.
 2021-04-27 12:11:39 -04:00
Rangi
316fa4b695 Use rgbds 0.5.0 2021-04-19 16:31:37 -04:00
Rangi
bf688645b1 Rename SOUND_REST to SOUND_CRY 
Fixes #821
 2021-04-12 14:48:05 -04:00
Rangi
94057c7726 Verify uneven list sizes with list_start, li, and assert_list_length macros 
This was discussed in #815
 2021-03-22 17:17:08 -04:00
Rangi
dbe2360ecd Miscellaneous cleanup 2021-03-22 16:41:17 -04:00
Rangi
5037adc55f Clean up some macro definitions 2021-03-21 20:09:34 -04:00
Rangi
90ce126139 Use numeric constants in text strings with "{d:interpolation}" 2021-03-21 18:14:31 -04:00
Rangi
0506e5b1b9 Assert the sBox1-14 tables have NUM_BOXES entries 2021-03-21 17:47:53 -04:00
Rangi
4522162d45 Consistent labels for each nickname in RAM 2021-03-17 16:38:21 -04:00
Rangi
6c8f8609cb Assert some more table widths 2021-03-17 11:38:01 -04:00
Rangi
3684296583 Revise some constant definitions 2021-03-16 18:06:18 -04:00
Rangi
dbabd8b4a9 Define MAPGROUP_* constants and verify MapGroup_* table sizes 2021-03-10 21:16:54 -05:00
Rangi
71073a5f3b Verify RAM table lengths 2021-03-09 20:43:24 -05:00
Rangi
98da09b3e9 Define more struct offset constants with rsreset instead of const_def 
This was discussed in #739
 2021-03-04 18:15:38 -05:00
Rangi
40902ffe24 Verify data table sizes with table_width and assert_table_length macros 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
 2021-03-04 00:15:03 -05:00