From 68cc985b8c69d4d2e3a480d24e43a4da505d2d06 Mon Sep 17 00:00:00 2001 From: Dylan Date: Sun, 1 Feb 2026 16:17:41 +0000 Subject: [PATCH] Small fix for Activity embeds + non-discord clients --- activity.py | 5 ++++- twitfix.py | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/activity.py b/activity.py index 6780067..bd6264f 100644 --- a/activity.py +++ b/activity.py @@ -35,7 +35,10 @@ def tweetDataToActivity(tweetData,embedIndex = -1): if media is not None: media = deepcopy(media) if media['type'] == "gif": - media['type'] = "gifv" + if "/convert.avif" in media['url']: + media['type'] = "image" + else: + media['type'] = "gifv" if 'thumbnail_url' not in media: media['thumbnail_url'] = media['url'] if media['type'] == "image" and "?" not in media['url']: diff --git a/twitfix.py b/twitfix.py index 982a3bd..f6860c9 100644 --- a/twitfix.py +++ b/twitfix.py @@ -433,7 +433,8 @@ def twitfix(sub_path): elif not embeddingMedia: return Response(renderTextTweetEmbed(tweetData),headers={"Cache-Tag": "embed"}) else: - media = determineMediaToEmbed(embedTweetData,embedIndex) + tryGifConversion = "Discord" in user_agent + media = determineMediaToEmbed(embedTweetData,embedIndex,convertGif=tryGifConversion) suffix="" if "suffix" in media: suffix = media["suffix"] @@ -442,7 +443,7 @@ def twitfix(sub_path): elif media['type'] == "video": return Response(renderVideoTweetEmbed(tweetData,media,appnameSuffix=suffix,embedIndex=embedIndex),headers={"Cache-Tag": "embed"}) elif media['type'] == "gif": - if "originalUrl" in media and media["url"] != media["originalUrl"]: + if "originalUrl" in media and media["url"] != media["originalUrl"] and tryGifConversion: return Response(renderImageTweetEmbed(tweetData,media['url'] , appnameSuffix=suffix,embedIndex=embedIndex),headers={"Cache-Tag": "embed"}) else: return Response(renderVideoTweetEmbed(tweetData,media,appnameSuffix=suffix,embedIndex=embedIndex),headers={"Cache-Tag": "embed"})