From 01fc42397fa305750f81eb781f9c8af3ea7b7d97 Mon Sep 17 00:00:00 2001 From: Sander in 't Veld Date: Fri, 27 Jul 2018 15:50:58 +0200 Subject: [PATCH] The return value of readlink is a signed size_t. --- src/discord_register_linux.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/discord_register_linux.cpp b/src/discord_register_linux.cpp index 0a739a7..34f8701 100644 --- a/src/discord_register_linux.cpp +++ b/src/discord_register_linux.cpp @@ -33,13 +33,11 @@ extern "C" DISCORD_EXPORT void Discord_Register(const char* applicationId, const char exePath[1024]; if (!command || !command[0]) { - size_t size = readlink("/proc/self/exe", exePath, sizeof(exePath)); - if (size <= 0) { + ssize_t size = readlink("/proc/self/exe", exePath, sizeof(exePath)); + if (size <= 0 || size >= sizeof(exePath)) { return; } - if (size < sizeof(exePath)) { - exePath[size] = '\0'; - } + exePath[size] = '\0'; command = exePath; }