From beb90226fe440e62a9df7868af642a395eb0fbf1 Mon Sep 17 00:00:00 2001 From: Diavolo Date: Fri, 26 May 2023 19:19:43 +0200 Subject: [PATCH] maint(compression): pass args by reference Co-authored-by: William Roy --- src/main.cpp | 2 +- src/utils/compression.cpp | 4 ++-- src/utils/compression.hpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main.cpp b/src/main.cpp index d04f2e6..9a44477 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -35,7 +35,7 @@ int main(const int argc, const char** argv) try { - unsafe_main(argc > 1 ? static_cast(atoi(argv[1])) : 20810); + unsafe_main(argc > 1 ? static_cast(std::strtol(argv[1], nullptr, 10)) : 20810); } catch (std::exception& e) { diff --git a/src/utils/compression.cpp b/src/utils/compression.cpp index f103eb0..1ee4829 100644 --- a/src/utils/compression.cpp +++ b/src/utils/compression.cpp @@ -134,9 +134,9 @@ namespace utils::compression } } - void archive::add(std::string filename, std::string data) + void archive::add(const std::string& filename, const std::string& data) { - this->files_[std::move(filename)] = std::move(data); + this->files_[filename] = data; } bool archive::write(const std::string& filename, const std::string& comment) diff --git a/src/utils/compression.hpp b/src/utils/compression.hpp index dfe36ad..53ba95c 100644 --- a/src/utils/compression.hpp +++ b/src/utils/compression.hpp @@ -18,7 +18,7 @@ namespace utils::compression class archive { public: - void add(std::string filename, std::string data); + void add(const std::string& filename, const std::string& data); bool write(const std::string& filename, const std::string& comment = {}); private: