CG_ParseCodInfo crash #9

Closed
opened 2025-07-09 20:02:44 +00:00 by Future · 1 comment
Owner

0x1401BD53B

void __fastcall CG_ParseCodInfo(int localClientNum)
{
  int v1; // ebx
  const char *v2; // rdi
  const char *v3; // rax

  v1 = 139;
  do
  {
    v2 = CL_GetConfigString(v1 - 128);
    if ( !*v2 ) // crash here
      break;
    v3 = CL_GetConfigString(v1);
    if ( !dword_141646CA0 ) // cgs_t->localServer (cgsArray)
      Dvar_SetFromStringByNameFromSource(v2, v3, DVAR_SOURCE_SERVERCMD);
    ++v1;
  }
  while ( v1 - 139 < 128 );
}

s1-mod_0.0.1_20250709_213414.dmp

0x1401BD53B ``` void __fastcall CG_ParseCodInfo(int localClientNum) { int v1; // ebx const char *v2; // rdi const char *v3; // rax v1 = 139; do { v2 = CL_GetConfigString(v1 - 128); if ( !*v2 ) // crash here break; v3 = CL_GetConfigString(v1); if ( !dword_141646CA0 ) // cgs_t->localServer (cgsArray) Dvar_SetFromStringByNameFromSource(v2, v3, DVAR_SOURCE_SERVERCMD); ++v1; } while ( v1 - 139 < 128 ); } ``` [s1-mod_0.0.1_20250709_213414.dmp](/attachments/8f4b9e59-1bc7-406b-b5e3-f7ec9322fc81)
Author
Owner

Caused by 2e62c51809

Repro steps: Join a server -> Leave -> Wait for map to rotate -> Attempt to rejoin -> Instant crash after getting "unable to join game session" Com Error and clicking "Okay" to close the popup

Without the relocating assets patch, the crash does not happen; however, after attempting to join the same server after 5 map rotations, you are no longer able to enter the server due to the "unable to join game session" error. Unknown cause

Caused by https://git.alterware.dev/alterware/s1-mod/commit/2e62c5180942828cf4c03cfa8772110f151c797c Repro steps: Join a server -> Leave -> Wait for map to rotate -> Attempt to rejoin -> Instant crash after getting "unable to join game session" Com Error and clicking "Okay" to close the popup Without the relocating assets patch, the crash does not happen; however, after attempting to join the same server after 5 map rotations, you are no longer able to enter the server due to the "unable to join game session" error. Unknown cause
This repo is archived. You cannot comment on issues.
No labels
1 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: alterware/s1-mod#9