gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2026-09-22 13:47:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Halt processing when any ambiguous-transparency colors exist (#2093)

Browse Source
This commit is contained in:
Rangi
2026-09-16 04:03:56 +02:00
committed by GitHub
parent f4c6221eb1
commit 004749ea75
4 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gfx/process.cpp
+12 -3
View File
@@ -218,6 +218,13 @@ struct Image {
}
}
}
if (size_t nbAmbiguousColors = ambiguous.size(); nbAmbiguousColors > 0) {
fatal(
"Image contains %zu ambiguous color%s (neither transparent nor opaque)",
nbAmbiguousColors,
nbAmbiguousColors == 1 ? "" : "s"
);
}
}
class TilesVisitor {
@@ -1056,12 +1063,14 @@ void process() {
for (auto tile : image.visitAsTiles()) {
AttrmapEntry &attrs = attrmap.emplace_back();
// Count the unique non-transparent colors for packing
// Count the unique opaque colors for packing
std::unordered_set<uint16_t> tileColors;
for (uint32_t y = 0; y < 8; ++y) {
for (uint32_t x = 0; x < 8; ++x) {
if (Rgba color = tile.pixel(x, y);
color.isOpaque() || !options.hasTransparentPixels) {
Rgba color = tile.pixel(x, y);
// Ambiguous colors should not be in `tileColors`
assume(color.isOpaque() != color.isTransparent());
if (color.isOpaque() || !options.hasTransparentPixels) {
tileColors.insert(color.cgbColor());
}
}