Fix buffer overflow when creating patches with long RPN expressions

Browse Source

The createpatch() function was using a fixed-size buffer. I've changed it
to be dynamically allocated. I saw that the RPN format used in patches is
slightly different from the one used internally in the assembler, so I
added a new member to the Expression struct to track the patch size.

I've also limited the RPN expression length to 1MB. I realized that the
patch RPN expression could potentially be longer than the internal RPN
expression, so the internal expression would need a limit smaller than
UINT32_MAX. I thought 1MB would be a reasonable limit.

...

This commit is contained in:

dbrotz

2019-06-11 09:35:57 -07:00

parent 54e5bf0f0c

commit 015d2b0830

6 changed files with 91 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

0

test/asm/long-rpn-expression.out.pipe Normal file