gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 18:52:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a potential out-of-bounds array access in RGBGFX

Browse Source 
This was caught by ASAN for pokered's gfx/battle/minimize.png.
This commit is contained in:
Rangi
2021-05-01 22:33:54 -04:00
parent dcb8c69661
commit 04788e15af
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gfx/gb.c
View File

@@ -224,7 +224,11 @@ void create_mapfiles(const struct Options *opts, struct GBImage *gb,
if (!tile) if (!tile)
err(1, "%s: Failed to allocate memory for tile", err(1, "%s: Failed to allocate memory for tile",
__func__); __func__);
for (i = 0; i < tile_size; i++) { /*
* If the input image doesn't fill the last tile,
* `gb_i` will reach `gb_size`.
*/
for (i = 0; i < tile_size && gb_i < gb_size; i++) {
tile[i] = gb->data[gb_i]; tile[i] = gb->data[gb_i];
gb_i++; gb_i++;
} }