From 0553491107a9db1dbb72310825eebc1d7743501d Mon Sep 17 00:00:00 2001 From: Rangi42 Date: Mon, 20 Apr 2026 14:51:38 +0200 Subject: [PATCH] Replace a FIXME comment with an explanation of why we can't/won't "fix" it --- src/CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 5226837a..98aba0f4 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -12,7 +12,8 @@ add_library(common OBJECT target_compile_definitions(common PRIVATE "BUILD_VERSION_STRING=\"${GIT_REV}\"") find_package(BISON 3.0.0 REQUIRED) -# FIXME: Using a list would be cleaner, but is not supported by `bison_target` before CMake 4.0. +# BISON 4.0 deprecates passing this BISON_FLAGS string to `bison_target`'s `COMPILE_FLAGS`, +# in favor of passing a list to `OPTIONS`, but that would require dropping support for CMake <4.0. set(BISON_FLAGS "-Wall -Dlr.type=ielr") # Set some flags on versions that support them. if(BISON_VERSION VERSION_GREATER_EQUAL "3.5")