gbdev/rgbds
1
0
Fork 0
mirror of https://github.com/gbdev/rgbds.git synced 2025-11-21 02:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a reference being used after being invalidated (#1352)

Browse Source 
Your classic use-after-free bug.
This commit is contained in:
Eldred Habert
2024-03-13 03:19:01 +01:00
committed by GitHub
parent 42d32c72a6
commit 08066d4692
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/link/assign.cpp
View File

@@ -250,8 +250,11 @@ static void placeSection(Section &section) {
.size = .size =
(uint16_t)(freeSpace.address + freeSpace.size - section.org - section.size)} (uint16_t)(freeSpace.address + freeSpace.size - section.org - section.size)}
); );
// **`freeSpace` cannot be reused from this point on**, because `bankMem.insert`
// invalidates all references to itself!
// Resize the original space (address is unmodified) // Resize the original space (address is unmodified)
freeSpace.size = section.org - freeSpace.address; bankMem[spaceIdx].size = section.org - bankMem[spaceIdx].address;
} else { } else {
// The amount of free spaces doesn't change: resize! // The amount of free spaces doesn't change: resize!
freeSpace.size -= section.size; freeSpace.size -= section.size;