From 081f48404c8c645acb403dec82fc737542dc0129 Mon Sep 17 00:00:00 2001 From: Rangi42 Date: Sat, 3 May 2025 10:19:33 -0400 Subject: [PATCH] Remove a TODO comment about overlapping proto-palettes The original algorithm makes a simplifying assumption that one proto-palette does not fully contain another, and we have no particular reason to violate this condition. --- src/gfx/process.cpp | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/gfx/process.cpp b/src/gfx/process.cpp index 698bbf5e..ac8d4c9a 100644 --- a/src/gfx/process.cpp +++ b/src/gfx/process.cpp @@ -1204,17 +1204,6 @@ void process() { protoPalettes[n] = protoPalette; // Override them // Remove any other proto-palettes that we encompass // (Example [(0, 1), (0, 2)], inserting (0, 1, 2)) - // - // The following code does its job, except that references to the removed - // proto-palettes are not updated, causing issues. - // TODO: overlap might not be detrimental to the packing algorithm. - // Investigation is necessary, especially if pathological cases are found. - // - // for (size_t i = protoPalettes.size(); --i != n;) { - // if (protoPalette.compare(protoPalettes[i]) == ProtoPalette::WE_BIGGER) { - // protoPalettes.erase(protoPalettes.begin() + i); - // } - // } [[fallthrough]]; case ProtoPalette::THEY_BIGGER: